-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix #983 verify the whole array to check Parse.Objects into generic objects #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
771767f
Recursive function to deal with nested objects
dannywolfmx eb237a8
Merge branch 'master' into master
dannywolfmx a0f9264
Merge branch 'master' into master
dplewis bbc2acf
nits
dplewis ef20959
Fix editing
dplewis 03505c3
Merge branch 'master' into master
dplewis cf49a15
hoisting
dplewis 61d574d
Merge branch 'master' into master
dannywolfmx 3af59bb
Merge branch 'master' into master
acinader b7d184e
Merge branch 'master' into master
dplewis e632348
Merge branch 'master' into master
TomWFox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,15 +203,18 @@ export default class BrowserTable extends React.Component { | |
value = ''; | ||
} else if (type === 'Array') { | ||
if (value) { | ||
value = value.map(val => { | ||
if (val instanceof Parse.Object) { | ||
return val.toPointer(); | ||
} else if (val && typeof val.getMonth === 'function') { | ||
return { __type: "Date", iso: val.toISOString() }; | ||
} | ||
|
||
return val; | ||
}); | ||
const detectObject = (value) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same? |
||
if (Array.isArray(value)) { | ||
return value.map(detectObject); | ||
} else if (value instanceof Parse.Object) { | ||
return value.toPointer(); | ||
} else if (value && typeof value.getMonth === 'function') { | ||
return { __type: "Date", iso: value.toISOString() }; | ||
} else { | ||
return value; | ||
} | ||
}; | ||
value = detectObject(value); | ||
} | ||
} | ||
let wrapTop = Math.max(0, this.props.current.row * ROW_HEIGHT); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you pull this function out so its not in the middle of this huge if/else?