Fix routing paths on Windows #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
reviewed
Nov 29, 2016
| @@ -70,9 +70,9 @@ | |||
| "lint": "eslint ./", | |||
| "build": "babel src/ -d lib/", | |||
| "test": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.2.6} MONGODB_STORAGE_ENGINE=mmapv1 NODE_ENV=test TESTING=1 $COVERAGE_OPTION jasmine", | |||
| "test:win": "npm run pretest && cross-env NODE_ENV=test TESTING=1 node ./node_modules/jasmine/bin/jasmine.js && npm run posttest", | |||
| "test:win": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.2.6} MONGODB_STORAGE_ENGINE=mmapv1 NODE_ENV=test TESTING=1 jasmine", | |||
There was a problem hiding this comment.
Seems that's the same as the test command now.
There was a problem hiding this comment.
There is a small difference in that test includes $COVERAGE_OPTION but this won't work on Windows
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 3, 2016
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures batch routing paths use posix separator
/on WindowsUpdated test:win and coverage:win to work again although mongodb-runner is not working on Windows