Password requirements message #4582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to 2.3.7
updating to 2.3.8
Added a custom passwordRequirementsHumanErrorMessage and clarified the reason for username containing fails
Closed
flovilmart
suggested changes
Feb 21, 2018
| @@ -319,7 +319,8 @@ var server = ParseServer({ | |||
| // 1. a RegExp object or a regex string representing the pattern to enforce | |||
| validatorPattern: /^(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])(?=.{8,})/, // enforce password with at least 8 char with at least 1 lower case, 1 upper case and 1 digit | |||
| // 2. a callback function to be invoked to validate the password | |||
| validatorCallback: (password) => { return validatePassword(password) }, | |||
| validatorCallback: (password) => { return validatePassword(password) }, | |||
| passwordRequirementsHumanErrorMessage: 'Password must contain a capital letter, lowercase letter, a number and be at least 8 characters long.', //This error message is sent instead of the generic "Password does not meet the Password Policy requirements." message. | |||
There was a problem hiding this comment.
can we rename to validationError ?
Codecov Report
@@ Coverage Diff @@
## master #4582 +/- ##
==========================================
+ Coverage 92.62% 92.87% +0.24%
==========================================
Files 119 118 -1
Lines 8558 8489 -69
==========================================
- Hits 7927 7884 -43
+ Misses 631 605 -26
Continue to review full report at Codecov.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pain: From the generic "password reset" page there is no way for the user to see the password requirements and the generic error leads to frustration.
Solution: I added a custom error message that the programmer can place in the config file that explains the requirements in human words.