Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password requirement custom message #5399

Merged

Conversation

pateldharad
Copy link
Contributor

Added a custom error message(validationError under password policy) that can explain specific password requirements for users. The message will get displayed on Password reset instead of generic error message.

Reference: #4582

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #5399 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5399      +/-   ##
==========================================
- Coverage   94.01%   93.99%   -0.03%     
==========================================
  Files         127      127              
  Lines        9091     9092       +1     
==========================================
- Hits         8547     8546       -1     
- Misses        544      546       +2
Impacted Files Coverage Δ
src/RestWrite.js 93.63% <100%> (-0.17%) ⬇️
src/Adapters/Auth/httpsRequest.js 95.23% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0db6eb...5a328e7. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks for helping to make parse-server better!

README.md Outdated Show resolved Hide resolved
@acinader acinader merged commit 6eaefd9 into parse-community:master Feb 28, 2019
@pateldharad pateldharad deleted the password_requirements_message branch March 11, 2019 00:07
@dplewis dplewis mentioned this pull request Mar 14, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Added validationError(custom message) for Password requirement fail

* Changed validationError from valodationError in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants