-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ws to the latest version 🚀 #6478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Merge On Green
label
Mar 8, 2020
ghost
approved these changes
Mar 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #6478 +/- ##
==========================================
- Coverage 93.96% 93.94% -0.03%
==========================================
Files 169 169
Lines 11801 11801
==========================================
- Hits 11089 11086 -3
- Misses 712 715 +3
Continue to review full report at Codecov.
|
noahsilas
added a commit
to noahsilas/parse-server
that referenced
this pull request
Mar 18, 2020
It's not clear what happened in parse-community#6478, but it appears that it dropped the `ws` dependency of the `parse` package when it was updating the local version of the dependency. This means that running `npm install` dirties the working tree, which is surprising! I've filed an issue for the surprising behavior from greenkeeper: greenkeeperio/greenkeeper-lockfile#250
noahsilas
added a commit
to noahsilas/parse-server
that referenced
this pull request
Mar 18, 2020
It's not clear what happened in parse-community#6478, but it appears that it dropped the `ws` dependency of the `parse` package when it was updating the local version of the dependency. This means that running `npm install` dirties the working tree, which is surprising! A similar problem seems to have occurred in parse-community#6504, that time related to the `commander` package. I've filed an issue for the surprising behavior from greenkeeper: greenkeeperio/greenkeeper-lockfile#250
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* fix(package): update ws to version 7.2.2 * chore(package): update lockfile package-lock.json Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io
The dependency ws was updated from
7.2.1
to7.2.2
.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Publisher: lpinca
License: MIT
Find out more about this release.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴