Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commander to the latest version 🚀 #6504

Merged
2 commits merged into from
Mar 14, 2020
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 14, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency commander was updated from 4.1.1 to 5.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: abetomo
License: MIT

Release Notes for v5.0.0

Added

  • support for nested commands with action-handlers ([#1] [#764] [#1149])
  • .addCommand() for adding a separately configured command ([#764] [#1149])
  • allow a non-executable to be set as the default command ([#742] [#1149])
  • implicit help command when there are subcommands (previously only if executables) ([#1149])
  • customise implicit help command with .addHelpCommand() ([#1149])
  • display error message for unknown subcommand, by default ([#432] [#1088] [#1149])
  • display help for missing subcommand, by default ([#1088] [#1149])
  • combined short options as single argument may include boolean flags and value flag and value (e.g. -a -b -p 80 can be written as -abp80) ([#1145])
  • .parseOption() includes short flag and long flag expansions ([#1145])
  • .helpInformation() returns help text as a string, previously a private routine ([#1169])
  • .parse() implicitly uses process.argv if arguments not specified ([#1172])
  • optionally specify where .parse() arguments "from", if not following node conventions ([#512] [#1172])
  • suggest help option along with unknown command error ([#1179])
  • TypeScript definition for commands property of Command ([#1184])
  • export program property ([#1195])
  • createCommand factory method to simplify subclassing ([#1191])

Fixed

  • preserve argument order in subcommands ([#508] [#962] [#1138])
  • do not emit command:* for executable subcommands ([#809] [#1149])
  • action handler called whether or not there are non-option arguments ([#1062] [#1149])
  • combining option short flag and value in single argument now works for subcommands ([#1145])
  • only add implicit help command when it will not conflict with other uses of argument ([#1153] [#1149])
  • implicit help command works with command aliases ([#948] [#1149])
  • options are validated whether or not there is an action handler ([#1149])

Changed

  • Breaking .args contains command arguments with just recognised options removed ([#1032] [#1138])
  • Breaking display error if required argument for command is missing ([#995] [#1149])
  • tighten TypeScript definition of custom option processing function passed to .option() ([#1119])
  • Breaking .allowUnknownOption() ([#802] [#1138])
    • unknown options included in arguments passed to command action handler
    • unknown options included in .args
  • only recognised option short flags and long flags are expanded (e.g. -ab or --foo=bar) ([#1145])
  • Breaking .parseOptions() ([#1138])
    • args in returned result renamed operands and does not include anything after first unknown option
    • unknown in returned result has arguments after first unknown option including operands, not just options and values
  • Breaking .on('command:*', callback) and other command events passed (changed) results from .parseOptions, i.e. operands and unknown ([#1138])
  • refactor Option from prototype to class ([#1133])
  • refactor Command from prototype to class ([#1159])
  • changes to error handling ([#1165])
    • throw for author error, not just display message
    • preflight for variadic error
    • add tips to missing subcommand executable
  • TypeScript fluent return types changed to be more subclass friendly, return this rather than Command ([#1180])
  • .parseAsync returns Promise<this> to be consistent with .parse() ([#1180])
  • update dependencies

Removed

  • removed EventEmitter from TypeScript definition for Command, eliminating implicit peer dependency on @types/node ([#1146])
  • removed private function normalize (the functionality has been integrated into parseOptions) ([#1145])
  • parseExpectedArgs is now private ([#1149])

Migration Tips

If you use .on('command:*') or more complicated tests to detect an unrecognised subcommand, you may be able to delete the code and rely on the default behaviour.

If you use program.args or more complicated tests to detect a missing subcommand, you may be able to delete the code and rely on the default behaviour.

If you use .command('*') to add a default command, you may be be able to switch to isDefault:true with a named command.

Commits

The new version differs by 53 commits.

  • 2aad525 Update dependencies (#1214)
  • f86d878 Add cli keyword (#1213)
  • 83af0fd Prepare for 5.0.0 (#1211)
  • f14df07 Add eslint settings for TypeScript (#1205)
  • 95e0d19 5.0.0-4
  • bd5a49e Add factory to CHANGELOG
  • 8c3dd6f createCommand factory routine (#1191)
  • 3c9f33f Say we support LTS, so do not need to update when node changes (#1204)
  • 3cf8cff Expand typescript checks (#1198)
  • a3f453f 5.0.0-3
  • 87bfca6 Add CHANGELOG entries for 5.0.0-3
  • 1757564 Use a tidier global command (#1200)
  • 0a50bd6 Add program to exports (#1195)
  • 77e511f Enable TypeScript checking of javascript, and resolve or suppress errors (#1194)
  • 2491c76 URLEncode several chinese toc link

There are 53 commits in total.

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #6504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6504   +/-   ##
======================================
  Coverage      94%     94%           
======================================
  Files         169     169           
  Lines       11825   11825           
======================================
  Hits        11116   11116           
  Misses        709     709
Impacted Files Coverage Δ
src/RestWrite.js 93.64% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2391f...0789ca0. Read the comment docs.

@ghost ghost merged commit 2c10d9e into master Mar 14, 2020
@greenkeeper greenkeeper bot deleted the greenkeeper/commander-5.0.0 branch March 14, 2020 04:22
noahsilas added a commit to noahsilas/parse-server that referenced this pull request Mar 18, 2020
It's not clear what happened in parse-community#6478, but it appears that it dropped
the `ws` dependency of the `parse` package when it was updating the
local version of the dependency. This means that running `npm install`
dirties the working tree, which is surprising!

A similar problem seems to have occurred in parse-community#6504, that time related to
the `commander` package.

I've filed an issue for the surprising behavior from greenkeeper:
greenkeeperio/greenkeeper-lockfile#250
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* fix(package): update commander to version 5.0.0

* chore(package): update lockfile package-lock.json

Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants