Skip to content

feat: Update graphql-yoga to v3 #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

feat: Update graphql-yoga to v3 #8521

wants to merge 7 commits into from

Conversation

coratgerl
Copy link
Contributor

@coratgerl coratgerl commented Apr 29, 2023

Pull Request

Issue

Closes: #8314

Approach

Update graphql-yoga package to v3, update GraphQLServer/Schema and adapt tests.

Add the package @whatwg-node/fetch, because the native fetch is not available under node 18 so we need @whatwg-node/fetch to support multipart.

Tasks

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: update graphql-yoga to v3 feat: Update graphql-yoga to v3 Apr 29, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -9.25 ⚠️

Comparison is base (9e43bc2) 94.35% compared to head (23ee37c) 85.10%.

❗ Current head 23ee37c differs from pull request most recent head f9b2cc8. Consider uploading reports for the commit f9b2cc8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8521      +/-   ##
==========================================
- Coverage   94.35%   85.10%   -9.25%     
==========================================
  Files         183      183              
  Lines       14515    14508       -7     
==========================================
- Hits        13695    12347    -1348     
- Misses        820     2161    +1341     
Impacted Files Coverage Δ
src/GraphQL/ParseGraphQLServer.js 97.61% <85.71%> (+3.74%) ⬆️
src/GraphQL/parseGraphQLUtils.js 92.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coratgerl coratgerl marked this pull request as draft April 29, 2023 21:44
@coratgerl coratgerl closed this by deleting the head repository Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to GraphQL Yoga 3
1 participant