Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Live query throws error when constraint notEqualTo is set to null #8835

Merged
merged 14 commits into from
Jun 11, 2024
Merged

fix: Live query throws error when constraint notEqualTo is set to null #8835

merged 14 commits into from
Jun 11, 2024

Conversation

RahulLanjewar93
Copy link
Contributor

@RahulLanjewar93 RahulLanjewar93 commented Dec 14, 2023 •
edited
Loading

failing Test case for issue #8834
adding this so pr is not closed. closes #8834

image

@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: failing test case for constraint notEqualTo null test: Failing test case for constraint notEqualTo null Dec 14, 2023
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Dec 14, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

mtrezza
mtrezza requested changes Dec 16, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in package-lock.json

mtrezza
mtrezza requested changes Dec 16, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not expect anything, please add a check to the test

@RahulLanjewar93
Copy link
Contributor Author

RahulLanjewar93 commented Dec 16, 2023 •
edited
Loading

This test does not expect anything, please add a check to the test

Actually, the server itself crashes since we are not handling the error thrown inside matchesKeyConstraints.
Which is why i have not added any expect

@RahulLanjewar93 RahulLanjewar93 force-pushed the test-live-query-failing-for-notEqualTo-null branch from e8137a6 to cced89c Compare December 16, 2023 07:01
mtrezza
mtrezza requested changes Dec 16, 2023
View reviewed changes
spec/ParseLiveQuery.spec.js Outdated Show resolved Hide resolved
@RahulLanjewar93 RahulLanjewar93 changed the title test: Failing test case for constraint notEqualTo null test: failing test case for constraint notEqualTo null Dec 16, 2023
@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: failing test case for constraint notEqualTo null test: Failing test case for constraint notEqualTo null Dec 16, 2023
@mtrezza
Update spec/ParseLiveQuery.spec.js
d3b9fc3 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
a6ea95b 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
d899544 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
502acc4 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
9260e40 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
87f12c9 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Update spec/ParseLiveQuery.spec.js
263b8c8 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Copy link
Member

mtrezza commented Dec 16, 2023 •
edited
Loading

I believe the test looks good now; do you have any suggestion for a fix?

@RahulLanjewar93
Copy link
Contributor Author

I believe the test looks good now; do you have any suggestion for a fix?

parse-server/src/LiveQuery/QueryTools.js

Line 226 in 2c2563e

if (compareTo.__type) {

this line should have optional chaining in my opinion

@RahulLanjewar93 RahulLanjewar93 changed the title test: Failing test case for constraint notEqualTo null fix: Live query throws error when constraint notEqualTo is set to null May 31, 2024
@RahulLanjewar93 RahulLanjewar93 mentioned this pull request May 31, 2024
Closed
@RahulLanjewar93 RahulLanjewar93 requested a review from mtrezza June 3, 2024 04:37
mtrezza
mtrezza approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (716925e) to head (532a2ed).

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #8835   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         186      186           
  Lines       14726    14726           
=======================================
  Hits        13865    13865           
  Misses        861      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 11d3e48 into parse-community:alpha Jun 11, 2024
22 of 26 checks passed
parseplatformorg pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
chore(release): 7.1.0-alpha.10 [skip ci]
162c07b 
# [7.1.0-alpha.10](7.1.0-alpha.9...7.1.0-alpha.10) (2024-06-11)

### Bug Fixes

* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.10

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 11, 2024
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
@semantic-release-bot
chore(release): 7.1.0-beta.1 [skip ci]
91dde99 
# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
@semantic-release-bot
chore(release): 7.1.0 [skip ci]
4906644 
# [7.1.0](7.0.0...7.1.0) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 30, 2024
@dplewis dplewis mentioned this pull request Nov 14, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Live Query] matchesKeyConstraints throwing error when constraints is {$ne : null}
3 participants
@RahulLanjewar93 @mtrezza @parseplatformorg