Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Parse JS SDK 5.2.0 #9128

Merged
merged 17 commits into from
Jun 29, 2024

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented May 16, 2024

Closes: #9131

Copy link

parse-github-assistant bot commented May 16, 2024

Thanks for opening this pull request!

@mtrezza mtrezza force-pushed the feat/upgrade-parse branch 3 times, most recently from 75ead54 to 76c3a74 Compare May 16, 2024 17:31
@mtrezza mtrezza force-pushed the feat/upgrade-parse branch from c43af20 to 8cb38d6 Compare May 16, 2024 17:32
@mtrezza mtrezza linked an issue May 16, 2024 that may be closed by this pull request
@mtrezza
Copy link
Member Author

mtrezza commented May 16, 2024

@parse-community/server @parse-community/js-sdk could someone take a look at why this CI fails when upgrading the Parse JS SDK? It seems that there are a 6 or so tests that consistently fail.

@dplewis
Copy link
Member

dplewis commented Jun 6, 2024

@mtrezza @parse-community/server @parse-community/js-sdk Looks like parse-community/Parse-SDK-JS#1453 is the cause. Although attributes does take care of pending operations, those pending operation returned from toJSON are heavily used in cloud code.

@mtrezza mtrezza force-pushed the feat/upgrade-parse branch from ec50927 to 24e65a9 Compare June 24, 2024 21:46
@mtrezza
Copy link
Member Author

mtrezza commented Jun 24, 2024

test-upgrade to parse 5.2.0-beta.1, to see whether CI passes, i.e. whether parse-community/Parse-SDK-JS#2162 fixed the issue. Before merge: release parse 5.2.0 stable and upgrade to that in this PR.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 24, 2024

CI now fails using parse 5.2.0-beta.1 with:

  1. PushWorker pushStatus tracks push status per UTC offsets
  • Expected undefined to be 1.
  • Expected undefined to be 1.
  • Expected undefined to be 3.
  • Expected undefined to be 2.

Not sure whether this is related to parse-community/Parse-SDK-JS#2162, or a different issue. @dplewis if you could take a look...

@dplewis
Copy link
Member

dplewis commented Jun 24, 2024

It is related because sentPerUTCOffset and failed PerUTCOffset use dot notation even though they are saved as strings so a check is needed

@mtrezza
Copy link
Member Author

mtrezza commented Jun 25, 2024

@dplewis if you find the time to open a fix for this, that would be great

@mtrezza
Copy link
Member Author

mtrezza commented Jun 28, 2024

Test upgrade to parse 5.2.0-alpha.4, to see if parse-community/Parse-SDK-JS#2194 fixed the issue.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (885aa12) to head (d6d248d).

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9128      +/-   ##
==========================================
+ Coverage   93.80%   94.16%   +0.35%     
==========================================
  Files         186      186              
  Lines       14726    14726              
==========================================
+ Hits        13814    13867      +53     
+ Misses        912      859      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis
Copy link
Member

dplewis commented Jun 28, 2024

@mtrezza looks good to me 👍

@mtrezza
Copy link
Member Author

mtrezza commented Jun 29, 2024

Yes, finally, thanks for the fixes @dplewis

@mtrezza mtrezza marked this pull request as draft June 29, 2024 08:28
@mtrezza
Copy link
Member Author

mtrezza commented Jun 29, 2024

Changed to draft as to not merge it accidentally before changing the parse dependency to a stable release

@mtrezza mtrezza changed the title feat: Upgrade to parse 5.1.0 feat: Upgrade to parse 5.2.0 Jun 29, 2024
@mtrezza mtrezza marked this pull request as ready for review June 29, 2024 14:31
@mtrezza mtrezza changed the title feat: Upgrade to parse 5.2.0 feat: Upgrade to Parse JS SDK 5.2.0 Jun 29, 2024
@mtrezza mtrezza merged commit 665b8d5 into parse-community:alpha Jun 29, 2024
24 of 26 checks passed
parseplatformorg pushed a commit that referenced this pull request Jun 29, 2024
# [7.1.0-alpha.11](7.1.0-alpha.10...7.1.0-alpha.11) (2024-06-29)

### Features

* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.11

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 29, 2024
@mtrezza mtrezza deleted the feat/upgrade-parse branch June 29, 2024 22:07
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
# [7.1.0](7.0.0...7.1.0) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 30, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-beta.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Parse 5.1.0 fails
3 participants