-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to Parse JS SDK 5.2.0 #9128
Conversation
Thanks for opening this pull request! |
75ead54
to
76c3a74
Compare
c43af20
to
8cb38d6
Compare
@parse-community/server @parse-community/js-sdk could someone take a look at why this CI fails when upgrading the Parse JS SDK? It seems that there are a 6 or so tests that consistently fail. |
@mtrezza @parse-community/server @parse-community/js-sdk Looks like parse-community/Parse-SDK-JS#1453 is the cause. Although |
ec50927
to
24e65a9
Compare
test-upgrade to parse 5.2.0-beta.1, to see whether CI passes, i.e. whether parse-community/Parse-SDK-JS#2162 fixed the issue. Before merge: release parse 5.2.0 stable and upgrade to that in this PR. |
CI now fails using parse 5.2.0-beta.1 with:
Not sure whether this is related to parse-community/Parse-SDK-JS#2162, or a different issue. @dplewis if you could take a look... |
It is related because sentPerUTCOffset and failed PerUTCOffset use dot notation even though they are saved as strings so a check is needed |
@dplewis if you find the time to open a fix for this, that would be great |
Test upgrade to parse 5.2.0-alpha.4, to see if parse-community/Parse-SDK-JS#2194 fixed the issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9128 +/- ##
==========================================
+ Coverage 93.80% 94.16% +0.35%
==========================================
Files 186 186
Lines 14726 14726
==========================================
+ Hits 13814 13867 +53
+ Misses 912 859 -53 ☔ View full report in Codecov by Sentry. |
@mtrezza looks good to me 👍 |
Yes, finally, thanks for the fixes @dplewis |
Changed to draft as to not merge it accidentally before changing the parse dependency to a stable release |
# [7.1.0-alpha.11](7.1.0-alpha.10...7.1.0-alpha.11) (2024-06-29) ### Features * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
🎉 This change has been released in version 7.1.0-alpha.11 |
# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
🎉 This change has been released in version 7.1.0-beta.1 |
# [7.1.0](7.0.0...7.1.0) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
🎉 This change has been released in version 7.1.0 |
🎉 This change has been released in version 7.3.0-alpha.1 |
🎉 This change has been released in version 7.3.0-beta.1 |
🎉 This change has been released in version 7.3.0 |
Closes: #9131