Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test suites using UUID #9195

Closed

Conversation

ddrechse
Copy link
Contributor

Pull Request

This change uses the new testExclusionList feature to disable tests

Issue

Allows uptake of the new OracleStorageAdapter

Closes:

Approach

These are the testExclusions required for the OracleStorageAdapter

Tasks

None

Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are too vast, as they are breaking the line with it_id and indent all the test code. This makes it difficult to review the PR and ensure the there are no (accidental) changes in the test themselves.

For example:

it_id('75c39ae3-06ac-4354-b321-931e81c5a927')(
    'properly set badges to 1 with complex query #2903 #3022',

Not sure where these line breaks come from, I assume from your local lint or prettier settings? I don't think it's our prettier printWidth: 100 (which we should remove anyway), because running npm run prettier modifies a lot more unrelated code.

Edit: I'll go ahead and rewrite these changes...

@ddrechse
Copy link
Contributor Author

When I pushed the PR, it ran eslint as part of the pre checks. Ran it again in my branch


npm run lint                                        

> parse-server@7.3.0-alpha.1 lint
> flow && eslint --cache ./

No errors!
ddrechse@ddrechse-mac parse-server % git branch
  alpha
* useTestExclusionList

And this is .eslintrc.json

{
    "root": true,
    "extends": "eslint:recommended",
    "env": {
        "node": true,
        "es6": true
    },
    "parser": "@babel/eslint-parser",
    "plugins": [
        "flowtype"
    ],
    "parserOptions": {
        "ecmaVersion": 6,
        "sourceType": "module",
        "requireConfigFile": false
    },
    "rules": {
        "indent": ["error", 2, { "SwitchCase": 1 }],
        "linebreak-style": ["error", "unix"],
        "no-trailing-spaces": 2,
        "eol-last": 2,
        "space-in-parens": ["error", "never"],
        "no-multiple-empty-lines": 1,
        "prefer-const": "error",
        "space-infix-ops": "error",
        "no-useless-escape": "off",
        "require-atomic-updates": "off",
        "object-curly-spacing": ["error", "always"]
    },
    "globals": {
        "Parse": true
    }
}

Hopefully, I can configure these setting correctly and run with the fix option
Another approach is to remove all the new lines in the it_id definitions

Let me know

@mtrezza
Copy link
Member

mtrezza commented Jul 16, 2024

No worries; I'm correcting it in #9205, as to keep your PR unchanged for reference; found some other unrelated issues along the way too. I doubt it's eslint, I think it's prettier that creates the line breaks, because our lint-fix script doesn't create them neither

@ddrechse
Copy link
Contributor Author

Ok let me know.
I was trying to make those it_id's one line, i.e

-  it_id('af1111b5-3251-4b40-8f06-fb0fc624fa91')(
-    'should support legacy parse.com audience fields',
+  it_id('af1111b5-3251-4b40-8f06-fb0fc624fa91')('should support legacy parse.com audience fields',
     done => {
       const database = Config.get(Parse.applicationId).database.adapter.database;

But i swear prettier or eslint is reverting, imho

ddrechse@ddrechse-mac parse-server % git commit
husky > pre-commit (node v20.0.0)
⚠ Some of your tasks use `git add` command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

✔ Preparing...
✔ Running tasks...
✖ Prevented an empty git commit!
✔ Reverting to original state because of errors...
✔ Cleaning up... 

  ⚠ lint-staged prevented an empty git commit.
  Use the --allow-empty option to continue, or check your task configuration

Ok
let me know :)

@mtrezza
Copy link
Member

mtrezza commented Jul 16, 2024

It may be husky, it could be that prettier runs in the pre-commit handler. I'll go ahead and fix this...

@mtrezza mtrezza mentioned this pull request Jul 18, 2024
@mtrezza
Copy link
Member

mtrezza commented Jul 18, 2024

@ddrechse Could you please try to run the Oracle adapter CI with #9205? I tried to use all your test IDs from this PR here. If it works, then I'll go ahead and merge #9205 and we can close this PR here.

@mtrezza
Copy link
Member

mtrezza commented Jul 18, 2024

Superseded by #9205

@mtrezza mtrezza closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants