Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test IDs #9205

Merged
merged 11 commits into from
Jul 18, 2024
Merged

test: Add test IDs #9205

merged 11 commits into from
Jul 18, 2024

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 16, 2024 •
edited
Loading

This adds test IDs to be excluded in external adapter repos.

Based on #9195; reduced changes for easier review.

@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: add test IDs test: Add test IDs Jul 16, 2024
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jul 16, 2024 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

This was referenced Jul 16, 2024
Closed
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (4b04c22) to head (73aeb98).
Report is 34 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #9205      +/-   ##
==========================================
+ Coverage   93.46%   93.74%   +0.28%     
==========================================
  Files         186      184       -2     
  Lines       14762    14671      -91     
==========================================
- Hits        13797    13754      -43     
+ Misses        965      917      -48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza mentioned this pull request Jul 18, 2024
Merged
ddrechse
ddrechse approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ddrechse ddrechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's do it. Once this gets into alpha, i'll kick a build of the Storafe adapter using alpha

@mtrezza mtrezza merged commit 901cff5 into parse-community:alpha Jul 18, 2024
27 checks passed
@mtrezza mtrezza deleted the test-add-test-IDs branch July 18, 2024 13:41
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 18, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 3, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddrechse ddrechse ddrechse approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtrezza @parseplatformorg @ddrechse