Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p2] Flash supports page write and other fixes #2470

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

YutingYou
Copy link
Contributor

@YutingYou YutingYou commented Jul 13, 2022

Problem

  1. To improve firmware download speed, we need to make use of FLASH_TxData256B()

  2. We're using 80MHz in the P2 flash clock configuration while MX25R32 requires up to 60MHz clock speed.

Screen Shot 2022-07-13 at 15 10 48

  1. Minor fixes for SPI unit test

NOTE: This PR requires updating the prebootloader!

Steps to Test

  1. Run usb-dfu to update DVOS to confirm the speed is improved
  2. Update the prebootloader to observe the flash clock with an oscilloscope
  3. Run the unit test wiring/no_fixture_spi

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@YutingYou YutingYou requested a review from avtolstoy July 13, 2022 07:45
@avtolstoy
Copy link
Member

@YutingYou Can you double check that the updates are going to work fine?

  1. Update prebootloader with the change in this PR, use bootloader/system-part without this changeset
  2. Update bootloader
  3. Update system-part

@YutingYou
Copy link
Contributor Author

@avtolstoy Double checked it with your steps to use the new prebootloader to update the old bootloader/system-part1 and new bootloader/system-part1. All worked fine. When updating the system-part1, both usb-dfu and particle flash --serial system-part1.bin worked for me.

@avtolstoy
Copy link
Member

@YutingYou 🎉

@technobly technobly added this to the 5.0.0 milestone Jul 13, 2022
@technobly technobly changed the title Flash supports page write and other fixes [p2] Flash supports page write and other fixes Jul 13, 2022
@technobly technobly merged commit fe90a9b into develop Jul 13, 2022
@technobly technobly deleted the feature/flash-supports-page-write branch July 13, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants