Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl872x: revert the flash speed to 80MHz #2684

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

YutingYou
Copy link
Contributor

@YutingYou YutingYou commented Aug 15, 2023

Problem

This is a mistake I made in PR2470

The older datasheet indicates support for QSPI speeds of up to 60MHz, whereas the newer one indicates support for speeds of up to 80MHz.

Screenshot 2023-08-15 at 14 59 02

Realtek also tested MX25R32 with 80MHz speed:
Screenshot 2023-08-15 at 15 08 44

UM0404 Ameba Flash AVL-EN_20210621(45695).pdf
MX25R6435F v0.03.pdf
MX25R6435F v1.6.pdf

Solution

Revert the flash speed from 57MHz to 80MHz.

NOTE: This PR requires updating the prebootloader-part1!

Steps to Test

  1. Update the prebootloader to observe the flash clock with an oscilloscope
  2. Update prebootloader with the change in this PR, use bootloader/system-part without this changeset
  3. Update bootloader
  4. Update system-part

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@YutingYou
Copy link
Contributor Author

Test result with oscilloscope
image

Cross version test on DVOSv5.4.0

# Download vesion v5.4.0
device-os-flash --all-devices 5.4.0

# Update prebootboader-mbr
particle flash --serial prebootloader-part1-80MHz.bin

# Update user app, then it will trigger safe mode to update bootloader and system-part1
particle flash --usb /Users/yuting/Desktop/blank-80MHz-PR.bin

blank-80MHz-PR.bin.zip
prebootloader-part1-80MHz-PR.bin.zip

@avtolstoy avtolstoy added this to the 5.5.0-rc.1 milestone Aug 15, 2023
@avtolstoy avtolstoy merged commit 2b84c88 into develop Aug 15, 2023
1 check passed
@avtolstoy avtolstoy deleted the fix/revert-the-flash-speed-to-80MHz branch August 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants