-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OFFSET
#451
Conversation
…rsing phase to evaluating phase.
…rValue.cast` method.
Co-authored-by: Alan Cai <caialan@amazon.com>
…s.kt Co-authored-by: Alan Cai <caialan@amazon.com>
…`session` in `ExprValue.cast`.
…ql/partiql-lang-kotlin into configure-default-timezone
…into configure-default-timezone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition to the PIG domain looks good.
I have a few minor suggestions for the PR:
- Since this is the first task of issue Add support for
OFFSET
#422, this PR shouldn't be linked to close that issue. I would link the issue in the final task's PR - I'd rename the PR title to reflect this is adding
OFFSET
to the PIG domain - Try keeping the PR's commit history clearer by creating a new branch off the target branch for each new PR. Doing this will prevent non-relevant commits from appearing in the PR, which may confuse the reviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order needs changed for LIMIT
and OFFSET
in the visitor transform tasks
lang/src/org/partiql/lang/eval/visitors/VisitorTransformBase.kt
Outdated
Show resolved
Hide resolved
lang/src/org/partiql/lang/eval/visitors/GroupByPathExpressionVisitorTransform.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
============================================
+ Coverage 82.36% 82.37% +0.01%
- Complexity 1395 1399 +4
============================================
Files 171 171
Lines 10722 10741 +19
Branches 1766 1771 +5
============================================
+ Hits 8831 8848 +17
- Misses 1350 1351 +1
- Partials 541 542 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Will finish all the 3 tasks from issue #422 in this branch, and afterwards merge this PR into main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the PIG domain and VisitorTransform
changes.
For the remaining two tasks, I'd create separate PRs targeting this branch, add-OFFSET
. After those PRs are merged into add-OFFSET
, this PR can be looked at again.
Issue #422
Changes Details: