Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OFFSET #451

Merged
merged 32 commits into from
Oct 12, 2021
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
38f01c6
Changed adding default timezone offset to TIME WITH TIME ZONE from pa…
lziq Sep 22, 2021
ea06c69
Remove unnecessary files
lziq Sep 23, 2021
9728308
Modified comments
lziq Sep 23, 2021
49d23b1
Fix issue 410
lziq Sep 27, 2021
b86a559
Fix issue 410
lziq Sep 27, 2021
82147af
Provide an option in EvaluationSession to configure default timezone.
lziq Sep 28, 2021
dab08fc
Added curly braces for line 2419 in SqlParser
lziq Sep 28, 2021
2bd6c56
Added "DataTimeFormatter" qualifier for line 2420 and 2423 in SqlParser
lziq Sep 28, 2021
a407439
Removed git merge conflict in ask.kt
lziq Sep 28, 2021
1fe1b27
Removed git merge conflict in ask.kt
lziq Sep 28, 2021
27e167d
Changed code style
lziq Sep 28, 2021
5297a5e
Changed code style
lziq Sep 28, 2021
d5bfa8b
Changed code style
lziq Sep 28, 2021
6580491
Changed code style
lziq Sep 28, 2021
0e5d497
Changed code style
lziq Sep 28, 2021
fb754b3
Changed code style
lziq Sep 28, 2021
572acc8
Added more test cases for time evaluation
lziq Sep 28, 2021
27101f4
Changed new field type from Environment to EvaluationSession for `Exp…
lziq Sep 28, 2021
3353c93
Update lang/test/org/partiql/lang/eval/EvaluatingCompilerCastTest.kt
lziq Sep 28, 2021
5882c2e
Update lang/test/org/partiql/lang/eval/EvaluatingCompilerDateTimeTest…
lziq Sep 28, 2021
9748e44
Removed unused package import
lziq Sep 29, 2021
ff122ee
Provided kdoc for `defaultTimezoneOffset` in `EvaluationSession` and …
lziq Sep 29, 2021
919f725
Made changes to `settingDefaultTimezoneOffset` in `EvaluationSessionT…
lziq Sep 29, 2021
ba59139
Merge branch 'configure-default-timezone' of https://github.com/parti…
lziq Sep 29, 2021
f92ee58
Created helper function for default timezone offset cast test cases.
lziq Sep 29, 2021
b7ee8bf
Created helper function for default timezone offset time evaluation t…
lziq Sep 29, 2021
6740ce1
Merge branch 'main' of https://github.com/partiql/partiql-lang-kotlin…
lziq Sep 29, 2021
fded498
Added OFFSET in PIG domain.
lziq Sep 30, 2021
7ad23ee
Reverse the order of limit and offset for visitors.
lziq Sep 30, 2021
1523c50
Modified comments for EvaluationOrder in VisitorTransformBase.
lziq Sep 30, 2021
96f781f
Add offset to parser and ExprNode conversions (#453)
lziq Oct 6, 2021
ebc5977
Added OFFSET in evaluator (#455)
lziq Oct 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lang/resources/org/partiql/type-domains/partiql.ion
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@
(group (? group_by))
(having (? expr))
(order (? order_by))
(limit (? expr))))
(limit (? expr))
(offset (? expr))))
// end of sum expr

// Time
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class GroupByPathExpressionVisitorTransform(
val groupBy = unshadowedTransformer.transformExprSelect_group(node)
val having = currentAndUnshadowedTransformer.transformExprSelect_having(node)
val order = currentAndUnshadowedTransformer.transformExprSelect_order(node)
val offset = unshadowedTransformer.transformExprSelect_offset(node)
val limit = unshadowedTransformer.transformExprSelect_limit(node)
val metas = unshadowedTransformer.transformExprSelect_metas(node)

Expand All @@ -116,6 +117,7 @@ class GroupByPathExpressionVisitorTransform(
group = groupBy,
having = having,
order = order,
offset = offset,
limit = limit,
metas = metas)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ abstract class VisitorTransformBase : PartiqlAst.VisitorTransform() {
val setq = transformExprSelect_setq(node)
val project = transformExprSelect_project(node)
val order = transformExprSelect_order(node)
val offset = transformExprSelect_offset(node)
val limit = transformExprSelect_limit(node)
val metas = transformExprSelect_metas(node)
return PartiqlAst.build {
Expand All @@ -53,6 +54,7 @@ abstract class VisitorTransformBase : PartiqlAst.VisitorTransform() {
group = group,
having = having,
order = order,
offset = offset,
limit = limit,
metas = metas)
}
Expand Down