-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for merge attempts with blocked
state
#203
Conversation
Hello @pascalgn and @BigGillyStyle! Are there any updates regarding this PR? Thank you! |
Hi @SaraRavasio One option for you until this PR is merged is to put the following in your Github workflow file for your merge action: uses: BigGillyStyle/automerge-action@main I'm not planning on publishing a separate Action on the Marketplace, but you can just refer to my fork that includes just this one change. Just an option if you're interested, as this what we're doing at work for now. |
Thank you @BigGillyStyle ! I'll do that 🙏 |
Thanks for the PR! When there is functionality that is useful to even a few people, I'm usually happy to add it. However, especially as this functionality is maybe not useful to everyone, I would like to not have it as default. My suggestion would be to add a new configuration option, something like MERGE_READY_STATE, which would default to |
that would be great actually! |
@BigGillyStyle somehow the action doesn't really work, I get this |
@SaraRavasio We use this action daily, so I'm sure it works. However, one thing that is key is that the user account you use to do the auto-merge needs to have the permissions to overcome your branch protection settings. Thus, if the PR didn't pass its status checks or (as is the case for us) doesn't have the required number of approvals...we created a specific user account that is used just for this workflow that can overcome that issue. |
@pascalgn and @SaraRavasio Let me know if this is what you were thinking: #208 |
I've just merged #208, so if that addresses your problem, feel free to close this PR! 🙏 |
Thanks @pascalgn ! I'll close this PR. |
Fixes #200
I understand if you decide you do not want to merge this, as this may not be want the community wants. I did test this change on our own private repos at my company, and this works as long as we use a GH user account to merge that has the appropriate permissions (in our case...a "service user" that can bypass branch protection rules).