Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MERGE_READY_STATE option #208

Merged
merged 7 commits into from
Feb 18, 2023

Conversation

BigGillyStyle
Copy link
Contributor

This is based on the discussion in #203 and in particular this comment

@SaraRavasio
Copy link

nice one! but what if the MERGE_READY_STATE always has those values plus the one that can be passed? so it's not the default ones or the other but all of them.
would that make sense?
cc @pascalgn

@BigGillyStyle
Copy link
Contributor Author

what if the MERGE_READY_STATE always has those values plus the one that can be passed?

That's a bit of an API preference that I'll defer to @pascalgn Would it be better to have the items provided by MERGE_READY_STATE to be merged with the default or replace the default state entirely (as was done originally in this PR)? The downside of what you are suggesting is that you couldn't override the defaults. However, the upside is that you don't have to re-state (or necessarily even know about) the default values. I could see either case.

@pascalgn pascalgn merged commit 5407b38 into pascalgn:main Feb 18, 2023
@pascalgn
Copy link
Owner

Thanks for the PR, it's merged now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants