Enabling definition of multiple noise channels and noise channels in XY #647
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
a-corni
changed the title
|
This is starting to mix a fix and a feature 😅 |
I am stopping here ;) In a way it's a fix since everything was already there 😇 But yes I could make a separate PR with only the fix (SPAM in XY), and later merge this one with the rest that is more development, and merge it into develop |
a-corni
changed the title
|
@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ? |
Isn't that done here already? |
No I have only changed the name of the file 🙄 I will implement this then |
Then I think I don't get what you are referring to because I already see all the changes I thought were required |
Now I understand the confusion 😅 All done then |
tests/test_simulation.py
Outdated
| assert sim._hamiltonian._bad_atoms == { | ||
| "atom0": True, | ||
| "atom1": False, | ||
| "atom2": True, | ||
| "atom3": False, | ||
| } | ||
| assert len(sim._hamiltonian._collapse_ops) // 4 == n_collapse_ops |
There was a problem hiding this comment.
Maybe divide by len(reg.qubits) to be clearer?
Main changes: 21a47f3 Remove Register.rotate() (#642) 20e6765 FIX: Redefine slope of RampWaveform (#644) c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647) bcb78cc Enable digital simulation (#652) 0f6e3dd Improve access to output modulation durations (#663) 188d21d Remove deprecated noise arguments (#674) f303138 Adding relaxation noise channel (#675) 716b86b Centralize all backend imports from a single pulser.backends module (#678) 96a8c34 Add hyperfine dephasing rate to NoiseModel (#680) 4981ca6 Add optional default noise models to devices (#676) c695373 Rectangular lattice register and layout (#665)
kraus_ops.html