-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated noise arguments #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have couple of warnings.simplefilter to delete as well:
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/qutip_backend.py#L48
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L150
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L205
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L227
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L256
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L289
- https://github.com/pasqal-io/Pulser/blob/develop/pulser-simulation/pulser_simulation/simulation.py#L299
Ahh right, thanks for reminding me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
* Remove deprecated noise arguments * Fix UT * Fix formatting * Deleting simplefilters
Main changes: 21a47f3 Remove Register.rotate() (#642) 20e6765 FIX: Redefine slope of RampWaveform (#644) c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647) bcb78cc Enable digital simulation (#652) 0f6e3dd Improve access to output modulation durations (#663) 188d21d Remove deprecated noise arguments (#674) f303138 Adding relaxation noise channel (#675) 716b86b Centralize all backend imports from a single pulser.backends module (#678) 96a8c34 Add hyperfine dephasing rate to NoiseModel (#680) 4981ca6 Add optional default noise models to devices (#676) c695373 Rectangular lattice register and layout (#665)
This PR removes the already deprecated:
dephasing_prob
depolarizing_prob
effective_noise_probs