Enable definition of effective noise operators in all basis #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGSilveri
reviewed
Aug 6, 2024
tests/test_simulation.py
Outdated
| @@ -865,6 +855,73 @@ def test_noises_digital(matrices, noise, result, n_collapse_ops, seq_digital): | |||
| seq_digital.register.qubits | |||
| ) | |||
| trace_2 = res.states[-1] ** 2 | |||
| assert np.abs(np.trace(trace_2)) < 1 and not np.isclose( | |||
There was a problem hiding this comment.
Was the np.abs() needed because there was an imaginary part?
There was a problem hiding this comment.
It was not really needed, but just at some point I had some issues with this test and I was wondering if it was coming from there...
There was a problem hiding this comment.
Ok, let's revert it then!
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I fixed the issue in the test on #717 , it is unrelated |
Merged
HGSilveri
added a commit
that referenced
this pull request
Sep 20, 2024
**Main changes:** - Reworking the NoiseModel interface (#710) - Allow modification of the EOM setpoint without disabling EOM mode (#708) - Enable definition of effective noise operators in all basis (#716) - Add leakage (#720) - Support differentiability through Torch tensors (#703) - Add from_abstract_repr to Device and VirtualDevice (#727) - [FEAT] Handle batches with partial results (#707) - Add open batches to pulser-pasqal (#701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ \sqrt{2\gamma} \left |r \right>\left <r \right |$and$ \sqrt{2\gamma_h} \left |h \right>\left <h \right |$.