-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Handle batches with partial results #707
Conversation
12451d3
to
8df62b1
Compare
I was thinking of something along those lines too, I think it would be better than |
I think we both agree that the current format that we use to return results is limiting us and that there doesn't seem to be a nice way to include partial results within it.
This would give the user a workaround when something failed in the traditional method. We could also point the user to this alternative method through the error message. |
8df62b1
to
55bc208
Compare
55bc208
to
65ac5d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
Co-authored-by: Henrique Silvério <29920212+HGSilveri@users.noreply.github.com>
1332859
to
c844186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got why you needed so many changes in the tests but let me know if I got it wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for your work on this!
**Main changes:** - Reworking the NoiseModel interface (#710) - Allow modification of the EOM setpoint without disabling EOM mode (#708) - Enable definition of effective noise operators in all basis (#716) - Add leakage (#720) - Support differentiability through Torch tensors (#703) - Add from_abstract_repr to Device and VirtualDevice (#727) - [FEAT] Handle batches with partial results (#707) - Add open batches to pulser-pasqal (#701)
Currently if one of the job of a batch fails, it is impossible to retrieve the results for any jobs of the batch - this raises an exception. In this PR, I suggest instead to add
None
to the list of results for that submission when a job has no results. I don't know if returning None is the most idiomatic way to do this in pulser; I also contemplated creating a new subclass ofResult
calledEmptyResult
but I wanted to gather some feedback before going for that because it would imply some refactoring of theResult
class and I'm not entirely convinced it would bring much.