Allow specification of job IDs in RemoteResults #718
Conversation
| def _fetch_result(self, submission_id: str) -> typing.Sequence[Result]: | ||
| def _fetch_result( | ||
| self, submission_id: str, job_ids: list[str] | None | ||
| ) -> typing.Sequence[Result]: |
There was a problem hiding this comment.
Not a related change but, how have you defined which types are imported via typing.Type or imported at the top? It's just the abstract classes?
There was a problem hiding this comment.
It's basically everything except typing.Sequence so as to not confuse it with pulser.Sequence (I know, it's unfortunate naming but there's no going back now)
| for job in batch.ordered_jobs: | ||
| sdk_jobs = batch.ordered_jobs | ||
| if job_ids is not None: | ||
| ind_job_pairs = [ |
There was a problem hiding this comment.
Just to confirm, this is so we can retain the returned order that they came in? if we associate and order by the index?
There was a problem hiding this comment.
Yes, whenever job_ids are provided we want to return the results in the same order they were given. This is simultaneously ensuring that's the case and selecting only the relevant subset of jobs
RemoteResultsRemoteResults.batch_idandRemoteResults.job_idsjob_idsinPasqalCloud._fetch_result()These changes should be useful to PRs #701 and #707 .