Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Promote operators/gates #155

Closed
wants to merge 7 commits into from
Closed

[Feature] Promote operators/gates #155

wants to merge 7 commits into from

Conversation

EthanObadia
Copy link
Collaborator

@EthanObadia EthanObadia commented Apr 5, 2024

Finally, this PR has been merge with the PR #156.

@EthanObadia EthanObadia added the feature New feature or request label Apr 5, 2024
@EthanObadia EthanObadia self-assigned this Apr 5, 2024
@EthanObadia EthanObadia changed the title Add promote_ope function (#154) [Feature] Add promote_ope function (#154) Apr 5, 2024
@EthanObadia EthanObadia changed the title [Feature] Add promote_ope function (#154) [Feature] Promote operators/gates Apr 5, 2024
tests/test_digital.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks @EthanObadia. Comments from my side merely about typing and renaming.

pyqtorch/primitive.py Outdated Show resolved Hide resolved
pyqtorch/primitive.py Outdated Show resolved Hide resolved
pyqtorch/utils.py Outdated Show resolved Hide resolved
pyqtorch/utils.py Outdated Show resolved Hide resolved
pyqtorch/utils.py Outdated Show resolved Hide resolved
pyqtorch/primitive.py Show resolved Hide resolved
@EthanObadia EthanObadia changed the title [Feature] Promote operators/gates [Feature] Promote operators/gates [0] Apr 16, 2024
@EthanObadia EthanObadia changed the title [Feature] Promote operators/gates [0] [Feature] Promote operators/gates Apr 16, 2024
@EthanObadia EthanObadia deleted the eo/promote_ope branch April 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants