Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Using simple float values inside sympy function leads to incorrect wavefunction when using time-dependent block #492

Closed
vytautas-a opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working hamevo

Comments

@vytautas-a
Copy link
Collaborator

Say we define a time-dependent generator for HamEvo:

td_gen = omega * (sympy.sin(x * t) * X(0) + y * (t**2) * Y(1))

If x and y are instances of Parameter (t is the time parameter) the result of simulating HamEvo with such generator is correct. However, if either or both x and y are floats or tensors - the simulation result is wrong.

@vytautas-a vytautas-a added the bug Something isn't working label Jul 3, 2024
@RolandMacDoland
Copy link
Collaborator

@vytautas-a Would you be able to give it a try ?

@jpmoutinho
Copy link
Collaborator

To check again in PyQ once pasqal-io/pyqtorch#228 is done.

@vytautas-a
Copy link
Collaborator Author

Fixed by PR #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hamevo
Projects
None yet
Development

No branches or pull requests

3 participants