-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refact] Get rid of PyQTimeDependentEvolution #568
Conversation
This refactoring disables the embedding function call for |
Hey @vytautas-a can I mark this PR as ready ? |
@Roland-djee, well this PR here is currently more in the proposal stage. It depends also on another PR that I'll open in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @vytautas-a looks nice and clean. Minor renaming suggestions and comments. Will approve once addressed.
671b0a0
to
be9f3ff
Compare
0a65130
to
aada3f6
Compare
Co-authored-by: RolandMacDoland <9250798+RolandMacDoland@users.noreply.github.com>
Co-authored-by: RolandMacDoland <9250798+RolandMacDoland@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vytautas-a :)
Few minor things and then it should be good to go.
One thing, I see that the docs for the time-dependent HamEvo reads:
# create parameterized HamEvo block
hamevo = HamEvo(generator_td, 0.0, duration=duration)
Is passing 0.0
correct there? I thought the idea was to pass the time parameter in that argument?
Yes, the docs have to updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Substitute
PyQTimeDependentEvolution
class with proper call topyqtorch
's time-dependent functionality.