Skip to content

Commit

Permalink
cmd/golangorg: move test case that needs internet to live.txt
Browse files Browse the repository at this point in the history
One test case added in CL 388016 depends on production resources,
specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go
served by the production instance of the Go playground.

This would be caught by TryBots where internet access is disabled,
but that didn't happen due to golang/go#51444.

Updates golang/go#51181.
Fixes golang/go#51439.

Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5
Reviewed-on: https://go-review.googlesource.com/c/website/+/389394
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
  • Loading branch information
passionSeven committed Mar 2, 2022
1 parent 7595837 commit dd5f40b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 1 addition & 7 deletions cmd/golangorg/testdata/godev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,13 @@ GET https://go.dev/play/p/asdfasdf
body contains The Go Playground
body contains About the Playground

GET https://go.dev/play/p/MAohLsrz7JQ.go
header Content-Type == text/plain; charset=utf-8
body !contains The Go Playground
body !contains About the Playground
body contains Hello, 世界

GET https://golang.google.cn/play/p/asdfasdf
code == 500
body contains Sorry, but shared playground snippets are not visible in China.
body !contains The Go Playground
body !contains About the Playground

GET https://golang.google.cn/play/p/MAohLsrz7JQ.go
GET https://golang.google.cn/play/p/asdfasdf.go
code == 500
body contains Sorry, but shared playground snippets are not visible in China.

Expand Down
6 changes: 6 additions & 0 deletions cmd/golangorg/testdata/live.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,9 @@ POST https://go.dev/_/share
postbody
package main
body !contains UA-

GET https://go.dev/play/p/MAohLsrz7JQ.go
header Content-Type == text/plain; charset=utf-8
body !contains The Go Playground
body !contains About the Playground
body contains Hello, 世界

0 comments on commit dd5f40b

Please sign in to comment.