Merge pull request #696 from patchlevel/replace-phinal-with-phpat

Replace psalm plugin "phinal" with phpstan extension "phpat"

Author: DavidBadura

baseline.xml

@@ -24,11 +24,6 @@
       <code><![CDATA[$service::{$handler->method}(...)]]></code>
     </MixedMethodCall>
   </file>
-  <file src="src/Console/DoctrineHelper.php">
-    <ClassNotFinal>
-      <code><![CDATA[class DoctrineHelper]]></code>
-    </ClassNotFinal>
-  </file>
   <file src="src/Cryptography/DoctrineCipherKeyStore.php">
     <ArgumentTypeCoercion>
       <code><![CDATA[base64_decode($result['crypto_iv'])]]></code>

composer.json

@@ -37,13 +37,13 @@
   },
   "require-dev": {
     "ext-pdo_sqlite": "~8.2.0 || ~8.3.0 || ~8.4.0",
-    "cspray/phinal": "dev-main#9826c3407056a4618f8bba303800403e47ccb3a7",
     "doctrine/orm": "^2.18.0 || ^3.0.0",
     "infection/infection": "^0.29.12",
     "jangregor/phpstan-prophecy": "^2.0",
     "league/commonmark": "^2.6.1",
     "patchlevel/coding-standard": "^1.3.0",
     "patchlevel/event-sourcing-psalm-plugin": "^3.1.0",
+    "phpat/phpat": "^0.11.3",
     "phpbench/phpbench": "^1.4.1",
     "phpspec/prophecy-phpunit": "^2.3.0",
     "phpstan/phpstan": "^2.1.11",

composer.lock

@@ -2,6 +2,7 @@ includes:
 	- phpstan-baseline.neon
 	- vendor/phpstan/phpstan-phpunit/extension.neon
 	- vendor/jangregor/phpstan-prophecy/extension.neon
+	- vendor/phpat/phpat/extension.neon
 
 parameters:
 	level: max
@@ -13,3 +14,8 @@ parameters:
 			identifier: missingType.generics
 	reportUnmatchedIgnoredErrors: false
 
+services:
+	-
+		class: Patchlevel\EventSourcing\Tests\Architecture\FinalClassesTest
+		tags:
+			- phpat.test

phpstan.neon.dist

@@ -18,6 +18,5 @@
 
     <plugins>
         <pluginClass class="Patchlevel\EventSourcingPsalmPlugin\Plugin"/>
-        <pluginClass class="Cspray\Phinal\Plugin"/>
     </plugins>
 </psalm>

psalm.xml

@@ -5,11 +5,9 @@
 namespace Patchlevel\EventSourcing\Attribute;
 
 use Attribute;
-use Cspray\Phinal\AllowInheritance;
 use Patchlevel\EventSourcing\Subscription\RunMode;
 
 #[Attribute(Attribute::TARGET_CLASS)]
-#[AllowInheritance('You can create specific attributes with default group and run mode')]
 class Subscriber
 {
     public function __construct(

src/Attribute/Subscriber.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Patchlevel\EventSourcing\Tests\Architecture;
+
+use Patchlevel\EventSourcing\Attribute\Subscriber;
+use PHPat\Selector\Selector;
+use PHPat\Test\Builder\Rule;
+use PHPat\Test\PHPat;
+
+final class FinalClassesTest
+{
+    public function testFinalClasses(): Rule
+    {
+        return PHPat::rule()
+            ->classes(
+                Selector::AllOf(
+                    Selector::inNamespace('Patchlevel\EventSourcing'),
+                    Selector::NOT(Selector::isAbstract()),
+                    Selector::NOT(Selector::isInterface()),
+                    Selector::NOT(Selector::classname(Subscriber::class)),
+                ),
+            )
+            ->shouldBeFinal();
+    }
+}