Skip to content

Conversation

@DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura force-pushed the replace-phinal-with-phpat branch from e17e60e to 37109a7 Compare February 17, 2025 16:04
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 76.758ms (±0.00%) | 76.578ms (±0.00%) | +0.24%    | 35.340mb        | 35.347mb   | -0.02%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 52.412ms (±0.00%)  | 52.643ms (±0.00%)  | -0.44%    | 34.418mb        | 34.418mb   | +0.00%      |
| benchLoad10000Events ()                | 958.000μs (±0.00%) | 951.200μs (±0.00%) | +0.71%    | 34.418mb        | 34.418mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.195s (±0.00%) | 3.191s (±0.00%) | +0.11%    | 46.961mb        | 46.961mb   | +0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.017ms (±0.00%)   | 954.100μs (±0.00%) | +6.57%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchLoad10000Events ()                | 58.913ms (±0.00%)  | 58.556ms (±0.00%)  | +0.61%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchSave1Event ()                     | 1.152ms (±0.00%)   | 1.065ms (±0.00%)   | +8.17%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchSave10000Events ()                | 290.928ms (±0.00%) | 296.277ms (±0.00%) | -1.81%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchSave10000Aggregates ()            | 9.058s (±0.00%)    | 8.888s (±0.00%)    | +1.91%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 5.144s (±0.00%)    | 5.119s (±0.00%)    | +0.49%    | 34.458mb        | 34.458mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.336ms (±0.00%)   | 4.367ms (±0.00%)   | -0.70%    | 37.651mb        | 37.651mb   | +0.00%      |
| benchSave10000Events () | 334.661ms (±0.00%) | 337.424ms (±0.00%) | -0.82%    | 37.723mb        | 37.723mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 974.800μs (±0.00%) | 916.100μs (±0.00%) | +6.41%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchLoad10000Events ()                | 51.651ms (±0.00%)  | 51.763ms (±0.00%)  | -0.22%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchSave1Event ()                     | 1.095ms (±0.00%)   | 1.158ms (±0.00%)   | -5.47%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchSave10000Events ()                | 218.737ms (±0.00%) | 213.677ms (±0.00%) | +2.37%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.725s (±0.00%)    | 8.912s (±0.00%)    | -2.10%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.917s (±0.00%)    | 4.912s (±0.00%)    | +0.10%    | 34.344mb        | 34.344mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 976.300μs (±0.00%) | 898.100μs (±0.00%) | +8.71%    | 35.548mb        | 35.548mb   | +0.00%      |
| benchLoad10000Events ()                | 95.342ms (±0.00%)  | 94.911ms (±0.00%)  | +0.45%    | 35.548mb        | 35.548mb   | +0.00%      |
| benchSave1Event ()                     | 1.513ms (±0.00%)   | 1.621ms (±0.00%)   | -6.64%    | 35.548mb        | 35.548mb   | +0.00%      |
| benchSave10000Events ()                | 257.150ms (±0.00%) | 250.757ms (±0.00%) | +2.55%    | 35.550mb        | 35.552mb   | -0.01%      |
| benchSave10000Aggregates ()            | 12.864s (±0.00%)   | 13.302s (±0.00%)   | -3.29%    | 35.548mb        | 35.548mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 9.167s (±0.00%)    | 9.188s (±0.00%)    | -0.23%    | 36.050mb        | 36.050mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the replace-phinal-with-phpat branch from 37109a7 to 36b7a57 Compare February 18, 2025 08:36
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the final check we don't need anymore a extra tool, since psalm is already checking it itself.

If we want to drop psalm then this might get relevant again. I would say we should add this as soon we are dropping psalm.

@DavidBadura
Copy link
Member Author

It's also about replacing deptrac.

This is also a first step to replace deptrac in favor of phpat as we think this tool is better suited for our usecase.
@DanielBadura DanielBadura force-pushed the replace-phinal-with-phpat branch from 36b7a57 to 3d781db Compare June 18, 2025 12:19
@DanielBadura DanielBadura changed the base branch from 3.10.x to 3.12.x June 18, 2025 12:19
@DanielBadura
Copy link
Member

Let's get this rolling. Replacing deptrac can be done another time :)
I rebased this branch to latest minor.

@DanielBadura DanielBadura changed the title replace phinal with phpat Replace psalm plugin "phinal" with phpstan extension "phpat" Jun 18, 2025
@DavidBadura DavidBadura merged commit df79c70 into 3.12.x Jun 18, 2025
40 checks passed
@DavidBadura DavidBadura deleted the replace-phinal-with-phpat branch June 18, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants