Skip to content

Conversation

@DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Dec 30, 2024

Originally I wanted to add phpstan to analyse our test folder instead of replacing psalm. But psalm updates went wild in the last releases and introduced alot of noice, especially in our test folder. This then the motivation to finish the PR and supersede the pslam test analysing with phpstan.

See for example here the CI output: https://github.com/patchlevel/event-sourcing/actions/runs/15727095803/job/44319268404

@github-actions
Copy link

github-actions bot commented Dec 30, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 77.215ms (±0.00%) | 76.232ms (±0.00%) | +1.29%    | 35.339mb        | 35.275mb   | +0.18%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 53.018ms (±0.00%)  | 55.854ms (±0.00%)  | -5.08%    | 34.418mb        | 34.348mb   | +0.20%      |
| benchLoad10000Events ()                | 939.100μs (±0.00%) | 912.400μs (±0.00%) | +2.93%    | 34.418mb        | 34.348mb   | +0.20%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.184s (±0.00%) | 3.169s (±0.00%) | +0.48%    | 46.961mb        | 46.891mb   | +0.15%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 961.100μs (±0.00%) | 971.500μs (±0.00%) | -1.07%    | 34.458mb        | 34.457mb   | +0.00%      |
| benchLoad10000Events ()                | 56.591ms (±0.00%)  | 55.842ms (±0.00%)  | +1.34%    | 34.458mb        | 34.457mb   | +0.00%      |
| benchSave1Event ()                     | 1.126ms (±0.00%)   | 1.047ms (±0.00%)   | +7.54%    | 34.458mb        | 34.457mb   | +0.00%      |
| benchSave10000Events ()                | 284.265ms (±0.00%) | 297.849ms (±0.00%) | -4.56%    | 34.458mb        | 34.457mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.549s (±0.00%)    | 8.735s (±0.00%)    | -2.13%    | 34.458mb        | 34.458mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 5.077s (±0.00%)    | 5.075s (±0.00%)    | +0.05%    | 34.458mb        | 34.458mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.363ms (±0.00%)   | 4.331ms (±0.00%)   | +0.75%    | 37.651mb        | 37.650mb   | +0.00%      |
| benchSave10000Events () | 330.195ms (±0.00%) | 334.617ms (±0.00%) | -1.32%    | 37.723mb        | 37.653mb   | +0.19%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 921.600μs (±0.00%) | 966.500μs (±0.00%) | -4.65%    | 34.344mb        | 34.343mb   | +0.00%      |
| benchLoad10000Events ()                | 52.762ms (±0.00%)  | 51.309ms (±0.00%)  | +2.83%    | 34.344mb        | 34.343mb   | +0.00%      |
| benchSave1Event ()                     | 1.180ms (±0.00%)   | 1.122ms (±0.00%)   | +5.11%    | 34.344mb        | 34.343mb   | +0.00%      |
| benchSave10000Events ()                | 212.791ms (±0.00%) | 213.530ms (±0.00%) | -0.35%    | 34.344mb        | 34.343mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.166s (±0.00%)    | 8.510s (±0.00%)    | -4.03%    | 34.344mb        | 34.344mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.866s (±0.00%)    | 4.843s (±0.00%)    | +0.49%    | 34.344mb        | 34.344mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 908.800μs (±0.00%) | 958.000μs (±0.00%) | -5.14%    | 35.548mb        | 35.477mb   | +0.20%      |
| benchLoad10000Events ()                | 96.771ms (±0.00%)  | 94.887ms (±0.00%)  | +1.99%    | 35.548mb        | 35.478mb   | +0.20%      |
| benchSave1Event ()                     | 1.499ms (±0.00%)   | 1.740ms (±0.00%)   | -13.84%   | 35.548mb        | 35.477mb   | +0.20%      |
| benchSave10000Events ()                | 249.824ms (±0.00%) | 250.571ms (±0.00%) | -0.30%    | 35.552mb        | 35.479mb   | +0.20%      |
| benchSave10000Aggregates ()            | 12.497s (±0.00%)   | 12.491s (±0.00%)   | +0.05%    | 35.548mb        | 35.478mb   | +0.20%      |
| benchSave10000AggregatesTransaction () | 9.071s (±0.00%)    | 9.083s (±0.00%)    | -0.13%    | 36.050mb        | 35.980mb   | +0.19%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Base automatically changed from update-phpstan-to-v2 to 3.8.x January 2, 2025 12:49
@DanielBadura DanielBadura force-pushed the enable-phpstan-for-tests branch from b521015 to 7539acf Compare June 18, 2025 11:53
@DanielBadura DanielBadura changed the base branch from 3.8.x to 3.12.x June 18, 2025 11:53
@DanielBadura DanielBadura changed the title Enable PHPStan for the tests folder Enable PHPStan for the tests folder, Disable Pslam for test folder Jun 18, 2025
@DanielBadura DanielBadura changed the title Enable PHPStan for the tests folder, Disable Pslam for test folder Enable PHPStan for the tests folder, Disable Psalm for test folder Jun 18, 2025
… Remove psalm usage in test folder and remove according deps.

Update baselines
@DanielBadura DanielBadura force-pushed the enable-phpstan-for-tests branch from 054fb96 to 045f6f8 Compare June 18, 2025 12:01
@DanielBadura DanielBadura marked this pull request as ready for review June 18, 2025 12:02
@DanielBadura DanielBadura requested a review from DavidBadura June 18, 2025 12:02
@DanielBadura DanielBadura self-assigned this Jun 18, 2025
@DanielBadura DanielBadura added the enhancement New feature or request label Jun 18, 2025
@DanielBadura DanielBadura merged commit 5ca0c53 into 3.12.x Jun 18, 2025
40 checks passed
@DanielBadura DanielBadura deleted the enable-phpstan-for-tests branch June 18, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants