Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmuldo fixes #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

mmuldo fixes #1

wants to merge 3 commits into from

Conversation

mmuldo
Copy link

@mmuldo mmuldo commented Jul 26, 2019

  • removes lib32-nvidia-utils package (no longer exists)
  • adds missing become statements
  • prompts for local user and github user instead of hard-coding

@@ -1,9 +1,14 @@
---
- hosts: 127.0.0.1
connection: local
vars_prompt:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition! It's convenient for new installs, when all the user has is a command prompt. This way they don't have to open a config file, edit it to set these variables, before running dot-ansible.

However, the majority of the time, this playbook is called in a system where it's already installed. It's being run to update the system. It's annoying and unnecessary to prompt the user for this information each time.

My current idea for user specific information is an inventory file, named after the user, that can be loaded at run time. Could we maybe use the existence of that file, or better yet checking if the vars themselves are already set, to determine if we should prompt the user?

@@ -1,5 +1,6 @@
---
- name: Install dependencies
become: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@@ -36,7 +36,6 @@ facter
xf86-video-vesa
nvidia
nvidia-utils
lib32-nvidia-utils
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this had temporarily been removed when you installed your OS, but it is currently a arch package: https://www.archlinux.org/packages/multilib/x86_64/lib32-nvidia-utils/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants