-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmuldo fixes #1
base: master
Are you sure you want to change the base?
mmuldo fixes #1
Conversation
adds missing 'become's
@@ -1,9 +1,14 @@ | |||
--- | |||
- hosts: 127.0.0.1 | |||
connection: local | |||
vars_prompt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this addition! It's convenient for new installs, when all the user has is a command prompt. This way they don't have to open a config file, edit it to set these variables, before running dot-ansible.
However, the majority of the time, this playbook is called in a system where it's already installed. It's being run to update the system. It's annoying and unnecessary to prompt the user for this information each time.
My current idea for user specific information is an inventory file, named after the user, that can be loaded at run time. Could we maybe use the existence of that file, or better yet checking if the vars themselves are already set, to determine if we should prompt the user?
@@ -1,5 +1,6 @@ | |||
--- | |||
- name: Install dependencies | |||
become: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
@@ -36,7 +36,6 @@ facter | |||
xf86-video-vesa | |||
nvidia | |||
nvidia-utils | |||
lib32-nvidia-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this had temporarily been removed when you installed your OS, but it is currently a arch package: https://www.archlinux.org/packages/multilib/x86_64/lib32-nvidia-utils/
become
statements