Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support classifier #13

Merged
merged 5 commits into from
Nov 18, 2018
Merged

Conversation

usr42
Copy link
Contributor

@usr42 usr42 commented Nov 16, 2018

Support classifier and extension in dependencies, both in string and map notation.

Details about classifier: https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.dsl.DependencyHandler.html#N16F49

@patrikerdes
Copy link
Owner

patrikerdes commented Nov 17, 2018

I'm not sure if the build.gradle changes were intentional or a mistake, but I did not want them so I did a commit to revert the changes to that file.

@patrikerdes
Copy link
Owner

There were codenarc issues, I fixed them in your branch.

Please always run ./gradlew build and make sure it is successful before creating a PR.

@usr42
Copy link
Contributor Author

usr42 commented Nov 17, 2018

You are right, the build.gradle change was not intended. Sorry for that and the codenarc issue. I'll run the checks the next time.

@patrikerdes
Copy link
Owner

No worries.

I'm seeing a lot of failing tests both on Travis CI and when running locally, would you mind having a look at that?

@usr42
Copy link
Contributor Author

usr42 commented Nov 17, 2018

I've fixed the failing tests. ./gradlew clean check with SKIP_SLOW_INTEGRATION_TESTS ran successfully. I'm currently running without SKIP_SLOW_INTEGRATION_TESTS.

@patrikerdes
Copy link
Owner

LGTM

@patrikerdes patrikerdes merged commit 7f2db32 into patrikerdes:master Nov 18, 2018
@usr42 usr42 deleted the support_classifier branch November 18, 2018 13:16
This was referenced Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants