Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): Support classifier and extension #3995

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix(gradle): Support classifier and extension #3995

merged 1 commit into from
Jul 10, 2019

Conversation

ikesyo
Copy link
Collaborator

@ikesyo ikesyo commented Jul 1, 2019

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 1, 2019 •
edited
Loading

I can't sign the CLA due to cla-assistant/cla-assistant#451.

@ikesyo ikesyo changed the title [gradle] Support classifier and extension feat(gradle): Support classifier and extension Jul 1, 2019
@rarkins
Copy link
Collaborator

rarkins commented Jul 1, 2019

Is it possible to add a test for this case? Should fail on master but pass here.

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 2, 2019

Yes, I'll add a test for this!

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 3, 2019 •
edited
Loading

@rarkins I added a test! Could you please review this?

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 8, 2019 •
edited
Loading

@rarkins Is there any chance to get this reviewed? I had added a test case for this already.

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 9, 2019

/cc @corecanarias

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 9, 2019 •
edited
Loading

I really want the fix for Crashlytics: https://fabric.io/kits/android/crashlytics/install

compile('com.crashlytics.sdk.android:crashlytics:2.10.1@aar')

Without the change, even though updates will be detected, the replacement is removing the @aar suffix which is not expected.

@rarkins rarkins changed the title feat(gradle): Support classifier and extension fix(gradle): Support classifier and extension Jul 10, 2019
@rarkins rarkins merged commit bb5baaa into renovatebot:master Jul 10, 2019
@renovate-bot
Copy link
Collaborator

🎉 This PR is included in version 18.22.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 10, 2019

Thanks @rarkins!

@ikesyo ikesyo deleted the patch-1 branch July 10, 2019 11:13
@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 11, 2019

It appears that the regular expression does not support extension only forms such as com.crashlytics.sdk.android:crashlytics:2.10.1@aar. I'll send a follow-up pull request.

@ikesyo ikesyo mentioned this pull request Jul 11, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@corecanarias corecanarias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikesyo @CLAassistant @rarkins @renovate-bot @corecanarias