Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get stylelint working again #182

Merged
merged 10 commits into from
Nov 26, 2021
Merged

fix: Get stylelint working again #182

merged 10 commits into from
Nov 26, 2021

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Nov 22, 2021

The latest version of the vscode extension requires an upgrade to stylelint, which requires some configuration to enable scss

* main:
  feat: bumping husky to version 7 (#179)

# Conflicts:
#	website/package.json
#	website/yarn.lock
The latest version of the vscode extension requires an upgrade to stylelint, which requires some configuration to enable scss
@vercel
Copy link

vercel bot commented Nov 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/patronage/bubs-next/Bx2VD43XJV3mY38a4JHXhvJyyMZ2
✅ Preview: https://bubs-next-git-178-stylelint-patronage.vercel.app

@ccorda ccorda changed the title 178-stylelint fix: Get stylelint working again Nov 22, 2021
@ccorda ccorda linked an issue Nov 22, 2021 that may be closed by this pull request
@ccorda
Copy link
Contributor Author

ccorda commented Nov 22, 2021

I based this on the next 12 PR, one that is merged, then this can go on top.

"stylelint-scss": "^3.20.1"
"stylelint-config-prettier": "^9.0.3",
"stylelint-config-standard": "^24.0.0",
"stylelint-config-standard-scss": "^2.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated to 3.0.0 three days ago which uses stylelint-config-standard@24.0.0 and doesn't have any breaking changes so seems like a good update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we can just use a single dep in here (and remove stylelint-config-standard)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, its in stylelint-config-standard-scss's dependencies

Copy link
Collaborator

@chrisherold chrisherold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* main:
  feat: Next 12 upgrade (#180)

# Conflicts:
#	website/package.json
#	website/yarn.lock
@ccorda ccorda merged commit d3d73ca into main Nov 26, 2021
@ccorda ccorda deleted the 178-stylelint branch November 26, 2021 18:37
ccorda added a commit that referenced this pull request Nov 26, 2021
* main:
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
ccorda added a commit that referenced this pull request Dec 28, 2021
* main:
  simpler eslint config (no custom babel) (#185)
  chore: node minor dep upgrades (#188)
  docs: env variable with graphcdn
  fix bug in postheader loading wrong scss file
  fix env.sample domain for graphcdn
  fix: meta not respecting social variables, customized title (#176)
  feat: log wp admin users into front-end preview mode (#173)
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
  resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165)
  feat: new convenience plugins in wordpress admin (#166)
  feat: theme mod instead of acf options for preview mode url (#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Stylelint 1 Breaking Changes
2 participants