Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumping husky to version 7 #179

Merged
merged 4 commits into from
Nov 19, 2021
Merged

feat: bumping husky to version 7 #179

merged 4 commits into from
Nov 19, 2021

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Nov 19, 2021

To test:

  • pull
  • cd website
  • yarn install
  • add junk to the top of a JS file
  • go to commit it.

You should see the following, and you won't get to the commit stage.

yarn run v1.22.10
$ /Users/cameron/projects/bubs-next/website/node_modules/.bin/lint-staged
✔ Preparing...
⚠ Running tasks...
  ❯ Running tasks for *.{js,jsx,ts,tsx}
    ✖ eslint --fix [FAILED]
  ↓ No staged files match *.{css,scss} [SKIPPED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up...

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/patronage/bubs-next/D5aBv33siASvWYYRCFLx9F1GR415
✅ Preview: https://bubs-next-git-53-husky-patronage.vercel.app

@ccorda ccorda requested a review from kylehotchkiss November 19, 2021 15:52
@kylehotchkiss
Copy link
Member

I get an error about file executable flags (I don't think we have our local git setup to track file flags). Can you try removing your repo, recloning, and seeing if you can replicate?

❯ git commit
hint: The 'website/.husky/pre-commit' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
[53-husky 86866bb] test
 1 file changed, 4 insertions(+)

@ccorda ccorda linked an issue Nov 19, 2021 that may be closed by this pull request
@ccorda
Copy link
Contributor Author

ccorda commented Nov 19, 2021

Thanks Kyle. Tried on a totally fresh install, and now it works (successfully installing as executables as a part of the prepare step on first commit)

@ccorda ccorda changed the title bumping husky to version 7 feat: bumping husky to version 7 Nov 19, 2021
@ccorda
Copy link
Contributor Author

ccorda commented Nov 19, 2021

@kylehotchkiss green now, can you review?

Copy link
Member

@kylehotchkiss kylehotchkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just re-cloned and husky is now working as expected

@ccorda ccorda merged commit 9558618 into main Nov 19, 2021
@ccorda ccorda deleted the 53-husky branch November 19, 2021 19:20
ccorda added a commit that referenced this pull request Nov 19, 2021
* main:
  feat: bumping husky to version 7 (#179)

# Conflicts:
#	website/package.json
#	website/yarn.lock
ccorda added a commit that referenced this pull request Nov 26, 2021
* main:
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
ccorda added a commit that referenced this pull request Dec 28, 2021
* main:
  simpler eslint config (no custom babel) (#185)
  chore: node minor dep upgrades (#188)
  docs: env variable with graphcdn
  fix bug in postheader loading wrong scss file
  fix env.sample domain for graphcdn
  fix: meta not respecting social variables, customized title (#176)
  feat: log wp admin users into front-end preview mode (#173)
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
  resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165)
  feat: new convenience plugins in wordpress admin (#166)
  feat: theme mod instead of acf options for preview mode url (#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Husky consolidation and v5
2 participants