-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Get stylelint working again #182
Conversation
* main: feat: bumping husky to version 7 (#179) # Conflicts: # website/package.json # website/yarn.lock
The latest version of the vscode extension requires an upgrade to stylelint, which requires some configuration to enable scss
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/patronage/bubs-next/Bx2VD43XJV3mY38a4JHXhvJyyMZ2 |
I based this on the next 12 PR, one that is merged, then this can go on top. |
website/package.json
Outdated
"stylelint-scss": "^3.20.1" | ||
"stylelint-config-prettier": "^9.0.3", | ||
"stylelint-config-standard": "^24.0.0", | ||
"stylelint-config-standard-scss": "^2.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updated to 3.0.0 three days ago which uses stylelint-config-standard@24.0.0
and doesn't have any breaking changes so seems like a good update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we can just use a single dep in here (and remove stylelint-config-standard
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, its in stylelint-config-standard-scss
's dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* main: feat: Next 12 upgrade (#180) # Conflicts: # website/package.json # website/yarn.lock
* main: simpler eslint config (no custom babel) (#185) chore: node minor dep upgrades (#188) docs: env variable with graphcdn fix bug in postheader loading wrong scss file fix env.sample domain for graphcdn fix: meta not respecting social variables, customized title (#176) feat: log wp admin users into front-end preview mode (#173) fix: Get stylelint working again (#182) feat: Next 12 upgrade (#180) feat: bumping husky to version 7 (#179) resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165) feat: new convenience plugins in wordpress admin (#166) feat: theme mod instead of acf options for preview mode url (#163)
The latest version of the vscode extension requires an upgrade to stylelint, which requires some configuration to enable scss