Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Integrate styleguidekit-assets-default #2

Closed
20 tasks done
bmuenzenmeyer opened this issue Mar 28, 2016 · 4 comments
Closed
20 tasks done

Integrate styleguidekit-assets-default #2

bmuenzenmeyer opened this issue Mar 28, 2016 · 4 comments

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Mar 28, 2016

https://github.com/pattern-lab/styleguidekit-assets-default

  • Rename UI menu items to support pl-pattern-nav-template
  • Rename ishControlsVisible to support pl-ish-controls-template
  • Write to patternlab-data.js
  • Navigation not working yet
  • Rendering of pl-ish-controls-template
  • Rendering of pl-pattern-nav-template
  • Get a local copy of PL PHP v2 running

Reverse engineering of this styleguidekit template will handle a lot of the work

  • Delete patternlab_grunt.js and patternlab_gulp.js from core
  • [ONGOING] Reconcile other ways we've deviated from this styleguide (basePath, default pattern, etc)
  • [x ] Unit tests ?
  • Cleanup
@bmuenzenmeyer bmuenzenmeyer self-assigned this Mar 28, 2016
@bmuenzenmeyer
Copy link
Member Author

Making progress on this!
image

@geoffp
Copy link
Contributor

geoffp commented Apr 3, 2016

Excellent!

@bmuenzenmeyer
Copy link
Member Author

Just be aware of the massive rename for keys. Think I got everything but
another glance would be great.

On Sun, Apr 3, 2016, 9:04 AM Geoff Pursell notifications@github.com wrote:

Excellent!


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2 (comment)

@bmuenzenmeyer
Copy link
Member Author

Got a reference installation of edition-php-development running for v2 on Windows 10 tonight. Should help race toward feature parity on integration of shared repos.

image

Noted tonight that #5 #6 #7 #8 look to be incomplete upstream

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants