Show "CSS" and "JS" tabs in code sections #330
Conversation
patternlab v1.2.1
* Underscored Patterns are being built on the UI if styleguide excludes was missing or empty closes #300 * bumping version for 1.2.2
Conflicts: core/lib/lineage_hunter.js core/lib/list_item_hunter.js core/lib/media_hunter.js core/lib/object_factory.js core/lib/parameter_hunter.js core/lib/pattern_assembler.js core/lib/pattern_exporter.js core/lib/patternlab.js core/lib/patternlab_grunt.js core/lib/patternlab_gulp.js core/lib/pseudopattern_hunter.js core/lib/style_modifier_hunter.js package.gulp.json package.json
shospodarets
changed the title
|
Hi @malyw |
|
Morning @malyw For some time now - the PL/Node roadmap has been focused on how to make repo as most know it more maintainable and align with bigger Pattern Lab 2.0 goals found in the PL/PHP parent project. Dave, Brad, and others are marching towards those goals, and so have I, albeit a bit slowly by the pace of most people's patience. My translation of these goals includes:
Every time that I accept a PR like this, it's taking a conscious step away from the goals above, in this case, unified frontend consumption. Other features like default start pattern will instantly regress when we move to consumption, the effort switching to backfilling by means of extending the shared logic or building a plugin + the framework needed. In the long time frame it's taken me to get where I am today on this journey, other PRs have come that are meeting the same fate as this one - they serve a valuable purpose but are either off of main-line development of 2.0 or are dead-ends. That's not to say this work is dead or a waste, it's just that the timing is awful (I am trying to get a 2.0-alpha out by mid June) and my resources are limited (newborn). So much more could be said... about the project, about my communication to you, about expectations in open source... but ultimately I've created something and people expect a certain degree of responsiveness. For the lack of communication, I am sorry. I do feel the roadmap points in the direction I've laid out, however, and has for some time. I see a few options. You can keep using PL/Node 1.X with this PR locally; it certainly sounds like a nice addition and I am sure you find utility in it. The larger community may not know how to consume it proper, however. I can accept this PR - and push it into a 1.X release, only to have it be ripped out by a 2.X release. That would get people using it if they so chose. Or, perhaps we can work together to start planning and building proper plugin support into PL/Node 2.X, which Dave has assured me is the proper home for this functionality in the future. |
|
Hey @bmuenzenmeyer, thanks for the extended answer. After a little thinking regarding that I propose to decline the Pull Request as actually it just adds showing the tabs without logic how they supposed to be used in patterns (in our application we include them separately)- it definitely may confuse the community. On the other hand I would be happy to discuss possibility of adding such a functionality (or similar) to the version 2.X as the roadmap promises the bright future. |
|
Thanks for your understanding - I am interested in making this a 2.X plugin one day. One of the best places to stay informed would be https://gitter.im/pattern-lab/node - where myself and @geoff often comment or discuss open items, work in progress, and general stuff too. You (and everyone) is welcome there! |
|
Thanks, just joined. |
Previous Pull Request- #115
was sent about a year ago and still has not been reviewed despite a positive feedback from developers.
This Pull Request provides updated code for patternlab 1.3.0 and would be closed in two weeks if it has the same destiny as the previous one.