2.0.0-alpha #361
Merged
2.0.0-alpha #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependence on pattern engines
object. The pattern_engines module returns an instance, but I now realize that this is a terrible idea.
Conflicts: builder/object_factory.js builder/pattern_assembler.js builder/pseudopattern_hunter.js
…rototype in the ES5 Object.create style
time that powers a real implementation of getEngineNameForPattern!
…pattern-engines Conflicts: builder/object_factory.js builder/parameter_hunter.js builder/pattern_assembler.js builder/patternlab.js
don't render at all, and are missing in the menu. The quest continues...
appear out of order in the nav menu.
oPatterns that delegate to PatternEngines. Remove requests to the pattern_assembler functions from hunters and replace them with calls to methods on oPattern. Also add new factory methods for oPatterns to be able to produce empty oPatterns and oPatterns with custom contents, which is useful both for unit testing and other internal use. This helps to cut down on usage of "bare" mustache strings.
faking oPatterns with incomplete object literals. This is a nice way to do it because it gives us a more accurate model of what happens at runtime, but also because we now really need oPatterns to be able to detect PatternEngines based on their file extensions for accurate testing.
PatternEngines: support multiple template engines, v2
to mustache! Hooray!
factory in the pseudopattern hunter; misc. code cleanup; hide some debug console.logs behind the flag
utilities module; move isPatternFile into pattern_engines module since that's where the knowledge it needs is concentrated
refactor patternName per styleguidekit-mustache-default key mismatch
string-length tomfoolery
Hopefully fix #347. Use Path tools and regex instead of hackish
installed. Fixes #352.
Make the engine unit tests chill out if their engines aren't installed
fixes#350
removing direct dependencies
passing unit test and passing npm linked private instance of PL closes #356
356 listitem bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.