Icons page redesign - add "copy unicode" functionality to icon table

[bdellasc]

Once the following are completed:

• PR 1840-Icons page redesign
• 2707-PatternFly font: Add icons, fix SVGs

...we should add a "copy unicode" function for each icon in the "All icons" table for consumers using the Font Awesome and PatternFly fonts in their non-Sketch design software.

CC: @gdoyle1 @evwilkin @mcoker @mcarrano

[mcoker]

@bdellasc one issue I see with this is that, if I recall correctly from our most recent font work, our font generator currently creates unicode based on the icons in alphabetical order. So if we add a new icon, unless its name is last in alphabetical order compared to the other icons, the unicode for every icon that follows the new icon will be different.

I'm wondering if there is another way for users to reference the icons other than the unicode? Or do we need to put some mechanism in place so that the unicode is preserved as we add/remove icons from the pficon font? Or can we offer the unicode in the table with a caveat that it may change as we add/remove icons from the font?

[bdellasc]

@mcoker It's a great question. I still have the old desktop (TTF) font installed as a reference. I can't recall if the icons within the TTF font get rendered in the same order as the icon order within the JSON file. If so, I could reorder/revert the icons in the JSON file to reflect the order of the icons in the old font file. Then we'd just add the new icons to the end of the list, so the original/old icon order is preserved and would keep the unicodes the same as the old font for any older icons.

Maybe we should synch up and do a quick test of this theory before any major work/workaround is attempted?

[bdellasc]

@mcoker I added the content string column (unicode) to the main icon list in the first tab and the updated recommendations in the second tab. I pulled all of the existing pf codes from the PF3 version of the desktop font. I also pulled in the codes from Font Awesome (since we also provided those in the PF3 table). Any content strings for new icons to the pf font are marked in red.

I'm not sure how we want to generate these new strings for the new pf icons. it might be just creating them sequentially "E0XX". Not sure how we test the implementation once we get the content strings defined in the JSON (or wherever they live)

https://docs.google.com/spreadsheets/d/1FwcP3qQm6zseNT-MKM2BwEmlu1La6KSmWe7i-9JzNFw/edit?usp=sharing (edited)

If you think it makes sense to meet with me and @evwilkin , I'm totally willing to do that