Update colors page #1772
Update colors page #1772
Conversation
|
PF3 preview: https://patternfly-org-pr-1772-v3.surge.sh/v3 |
There was a problem hiding this comment.
@redallen wow this is looking incredible. The comments you left about moving the hand pointer into the circle and the color palette not opening upon scroll are fine!
I found some small things that need to be fixed:
- For all of the hex values where the pattern of letters/numbers repeat, can we still show the full value? They are shortening to 3... for example #FFF should be #FFFFFF and #06C should be #0066CC
- The --pf-global--link-color is showing a hex value of #4080 and should be #0066CC
- For each group of status colors, each hex value should have a description next to the hex value... I forgot to put this in the google doc (my bad) but it's in the Marvel project. I did add it to the google doc this morning and will also list it here (one default hex will not have a description on purpose):
Danger
#470000 (alert icon)
#A30000 (alert title)
#C9190B (alert icon background)
Default
#3737 (alert title and icon)
#009596
#73C5C5 (alert icon background)
Info
#4368 (alert title and icon)
#73BCF7 (alert icon background)
Success
#0F280D (alert title and icon)
#3E8635 (alert icon background)
Warning
#795600 (alert title and icon)
#F0AB00 (alert icon background)
- Can we change "hex value" in the shadow tooltips to "value"?
-
In the color palette section, can we make it so when you hover over an expandable icon (the angle), your cursor becomes a pointer? Not seeing that now.
-
The expandable panel that drops down in the color palette table applies a different background color on hover - can we remove this (bg will stay #FFFFFF)? That interaction isn't needed since nothing can be selected within that panel.
- The hex values listed in the color families are using monospace instead of RHT (should be the same text as the palette color text listed to the left)
|
gdoyle1
left a comment
gdoyle1
left a comment
There was a problem hiding this comment.
@redallen this looks AMAZING.
One last change!!
Can we change the blue expansion color to white in the shadows color palette please? I understand that it will remove the indication that it has been expanded but it will be consistent with the other palettes that way.
THANK YOU
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
Closes #1517
Preview: https://patternfly-org-pr-1772-v4.surge.sh/v4/design-guidelines/styles/colors
Couple of differences from design:
Color palettes
Status and state colors
Status and state colors section is a little cramped compared to the design, which I don't think accounted for the space a side nav takes. Do we want to keep the 3 column layout or make the font smaller @gdoyle1 ?Color families
The shadows family has no shadows currently. It's included on one page in the design but not another... do we want it in or not @gdoyle1 ? I'm fixing it to look correct now just in case...