feat(MultipleFileUpload): update for penta #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-10031.surge.sh A11y report: https://patternfly-react-pr-10031-a11y.surge.sh |
Comment on lines
58
to
59
| <div className="pf-v5-c-multiple-file-upload__status-progress-icon">{icon}</div> | ||
| <div className="pf-v5-c-multiple-file-upload__status-progress-text">{statusToggleText}</div> |
Collaborator
Author
There was a problem hiding this comment.
Changed to hardcoded classes for now as I think the styling for these classes will likely be removed for #6247, which will make them unavailable on the styles object.
Contributor
There was a problem hiding this comment.
Rather than hardcoding the whole class:
Suggested change
| <div className="pf-v5-c-multiple-file-upload__status-progress-icon">{icon}</div> | |
| <div className="pf-v5-c-multiple-file-upload__status-progress-text">{statusToggleText}</div> | |
| <div className={`${styles.multipleFileUpload}__status-progress-icon`}>{icon}</div> | |
| <div className={`${styles.multipleFileUpload}__status-progress-text`}>{statusToggleText}</div> |
Should work
wise-king-sullyman
requested review from
a team,
andrew-ronaldson,
lboehling,
mfrances17,
nicolethoen and
srambach
and removed request for
a team
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Couple comments below, otherwise lgtm
Comment on lines
58
to
59
| <div className="pf-v5-c-multiple-file-upload__status-progress-icon">{icon}</div> | ||
| <div className="pf-v5-c-multiple-file-upload__status-progress-text">{statusToggleText}</div> |
Contributor
There was a problem hiding this comment.
Rather than hardcoding the whole class:
Suggested change
| <div className="pf-v5-c-multiple-file-upload__status-progress-icon">{icon}</div> | |
| <div className="pf-v5-c-multiple-file-upload__status-progress-text">{statusToggleText}</div> | |
| <div className={`${styles.multipleFileUpload}__status-progress-icon`}>{icon}</div> | |
| <div className={`${styles.multipleFileUpload}__status-progress-text`}>{statusToggleText}</div> |
Should work
| </div> | ||
| {/* TODO: Update with issue #9997. Removed class "styles.multipleFileUploadStatusItemClose" that no longer exists */} | ||
| <div> | ||
| <div className="pf-v5-c-multiple-file-upload__status-item-close"> |
thatblindgeye
approved these changes
Jan 26, 2024
nicolethoen
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9997
Additional issues:
Convenience link: https://patternfly-react-pr-10031.surge.sh/components/file-upload/multiple-file-upload