Skip to content

fix(select): remove the custom override on width #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jschuler merged 1 commit into from
Apr 15, 2019
Merged

fix(select): remove the custom override on width #1652

jschuler merged 1 commit into from
Apr 15, 2019

Conversation

@boaz0
Copy link
Member

@boaz0 boaz0 commented Mar 28, 2019

What:
This change removes width from defaultProps as width: 100% is set in the class.
closes #1610
//cc @christiemolloy @kmcfaul

@tlabaj tlabaj requested review from dlabaj and kmcfaul March 28, 2019 19:33
dlabaj
dlabaj previously approved these changes Apr 2, 2019
View reviewed changes
@boaz0
fix(select): remove the custom override on width
d410975 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7bc2fe0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1652   +/-   ##
=========================================
  Coverage          ?   82.82%           
=========================================
  Files             ?      585           
  Lines             ?     6475           
  Branches          ?       75           
=========================================
  Hits              ?     5363           
  Misses            ?     1082           
  Partials          ?       30
Flag Coverage Δ
#patternfly3 84.75% <ø> (?)
#patternfly4 79.69% <ø> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...rnfly-4/react-core/src/components/Select/Select.js 93.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc2fe0...d410975. Read the comment docs.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Apr 2, 2019

PatternFly-React preview: https://1652-pr-patternfly-react-patternfly.surge.sh

kmcfaul
kmcfaul approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tlabaj
tlabaj approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler jschuler merged commit e0f0309 into patternfly:master Apr 15, 2019
@boaz0
Copy link
Member Author

boaz0 commented Apr 15, 2019

Thank you all @kmcfaul, @tlabaj and @jschuler

@boaz0 boaz0 deleted the fixes_1610 branch April 15, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@dlabaj dlabaj dlabaj left review comments

+1 more reviewer

@jschuler jschuler jschuler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kmcfaul kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Select Width

7 participants

@boaz0 @codecov-io @patternfly-build @jschuler @dlabaj @tlabaj @kmcfaul