Skip to content

fix(select): remove the custom override on width #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschuler merged 1 commit into from
Apr 15, 2019
Merged

fix(select): remove the custom override on width #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/patternfly-4/react-core/src/components/Select/Select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const defaultProps = {
selections: null,
placeholderText: null,
variant: SelectVariant.single,
width: '100%'
width: null,
};

class Select extends React.Component {
Expand Down Expand Up @@ -105,7 +105,6 @@ class Select extends React.Component {
onEnter={this.onEnter}
onClose={this.onClose}
aria-labelledby={`${ariaLabelledBy} ${selectToggleId}`}
style={{ width }}
isCheckbox={variant === SelectVariant.checkbox}
>
{variant === SelectVariant.single && (
Expand Down
70 changes: 10 additions & 60 deletions packages/patternfly-4/react-core/src/components/Select/__snapshots__/Select.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,13 @@ exports[`checkbox select renders checkbox select groups successfully 1`] = `
placeholderText={null}
selections={null}
variant="checkbox"
width="100%"
width={null}
>
<div
className="pf-c-select pf-m-expanded"
style={
Object {
"width": "100%",
"width": null,
}
}
>
Expand All @@ -348,11 +348,6 @@ exports[`checkbox select renders checkbox select groups successfully 1`] = `
onEnter={[Function]}
onToggle={[MockFunction]}
parentRef={null}
style={
Object {
"width": "100%",
}
}
type="button"
>
<button
Expand All @@ -363,11 +358,6 @@ exports[`checkbox select renders checkbox select groups successfully 1`] = `
id="pf-toggle-id-4"
onClick={[Function]}
onKeyDown={[Function]}
style={
Object {
"width": "100%",
}
}
type="button"
>
<div
Expand Down Expand Up @@ -788,13 +778,13 @@ exports[`checkbox select renders closed successfully 1`] = `
placeholderText={null}
selections={null}
variant="checkbox"
width="100%"
width={null}
>
<div
className="pf-c-select"
style={
Object {
"width": "100%",
"width": null,
}
}
>
Expand All @@ -812,11 +802,6 @@ exports[`checkbox select renders closed successfully 1`] = `
onEnter={[Function]}
onToggle={[MockFunction]}
parentRef={null}
style={
Object {
"width": "100%",
}
}
type="button"
>
<button
Expand All @@ -827,11 +812,6 @@ exports[`checkbox select renders closed successfully 1`] = `
id="pf-toggle-id-2"
onClick={[Function]}
onKeyDown={[Function]}
style={
Object {
"width": "100%",
}
}
type="button"
>
<div
Expand Down Expand Up @@ -1063,13 +1043,13 @@ exports[`checkbox select renders expanded successfully 1`] = `
placeholderText={null}
selections={null}
variant="checkbox"
width="100%"
width={null}
>
<div
className="pf-c-select pf-m-expanded"
style={
Object {
"width": "100%",
"width": null,
}
}
>
Expand All @@ -1087,11 +1067,6 @@ exports[`checkbox select renders expanded successfully 1`] = `
onEnter={[Function]}
onToggle={[MockFunction]}
parentRef={null}
style={
Object {
"width": "100%",
}
}
type="button"
>
<button
Expand All @@ -1102,11 +1077,6 @@ exports[`checkbox select renders expanded successfully 1`] = `
id="pf-toggle-id-3"
onClick={[Function]}
onKeyDown={[Function]}
style={
Object {
"width": "100%",
}
}
type="button"
>
<div
Expand Down Expand Up @@ -1367,13 +1337,13 @@ exports[`select single select renders closed successfully 1`] = `
placeholderText={null}
selections={null}
variant="single"
width="100%"
width={null}
>
<div
className="pf-c-select"
style={
Object {
"width": "100%",
"width": null,
}
}
>
Expand All @@ -1391,11 +1361,6 @@ exports[`select single select renders closed successfully 1`] = `
onEnter={[Function]}
onToggle={[MockFunction]}
parentRef={null}
style={
Object {
"width": "100%",
}
}
type="button"
>
<button
Expand All @@ -1406,11 +1371,6 @@ exports[`select single select renders closed successfully 1`] = `
id="pf-toggle-id-0"
onClick={[Function]}
onKeyDown={[Function]}
style={
Object {
"width": "100%",
}
}
type="button"
>
<div
Expand Down Expand Up @@ -1571,13 +1531,13 @@ exports[`select single select renders expanded successfully 1`] = `
placeholderText={null}
selections={null}
variant="single"
width="100%"
width={null}
>
<div
className="pf-c-select pf-m-expanded"
style={
Object {
"width": "100%",
"width": null,
}
}
>
Expand All @@ -1595,11 +1555,6 @@ exports[`select single select renders expanded successfully 1`] = `
onEnter={[Function]}
onToggle={[MockFunction]}
parentRef={null}
style={
Object {
"width": "100%",
}
}
type="button"
>
<button
Expand All @@ -1610,11 +1565,6 @@ exports[`select single select renders expanded successfully 1`] = `
id="pf-toggle-id-1"
onClick={[Function]}
onKeyDown={[Function]}
style={
Object {
"width": "100%",
}
}
type="button"
>
<div
Expand Down