-
Notifications
You must be signed in to change notification settings - Fork 376
feat(build): incremental build #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PatternFly-React preview: https://1817-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 606 606
Lines 6688 6688
Branches 76 76
=======================================
Hits 5535 5535
Misses 1123 1123
Partials 30 30
Continue to review full report at Codecov.
|
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What: Build only packages whose
srcdirectories have changed since the last build. Renamereact-tokens/build->react-tokens/srcfor this reason, leavereact-iconsalone for now. Addbuild:pf3andbuild:pf4build targets.If you're a PF4 developer all you need to do is
yarn start:pf4and it will rebuild PF4 packages that are out of date. No moreyarn buildneeded for development!Additional issues: Need to verify this works on CI.