Skip to content

Conversation

@redallen
Copy link
Contributor

@redallen redallen commented Apr 22, 2019

What: Build only packages whose src directories have changed since the last build. Rename react-tokens/build -> react-tokens/src for this reason, leave react-icons alone for now. Add build:pf3 and build:pf4 build targets.

If you're a PF4 developer all you need to do is yarn start:pf4 and it will rebuild PF4 packages that are out of date. No more yarn build needed for development!

Additional issues: Need to verify this works on CI.

@redallen redallen changed the title Feat/incremental build feat(build): incremental build Apr 22, 2019
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1817-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #1817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1817   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ges/patternfly-4/react-tokens/src/templates/esm.js 100% <ø> (ø)
...es/patternfly-4/react-tokens/src/generateTokens.js 93.33% <ø> (ø)
...ges/patternfly-4/react-tokens/src/templates/cjs.js 100% <ø> (ø)
...es/patternfly-4/react-tokens/src/templates/d.ts.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a398042...0469b93. Read the comment docs.

@dgutride dgutride merged commit 6bd3d7e into patternfly:master Apr 25, 2019
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants