-
Notifications
You must be signed in to change notification settings - Fork 377
feat(react-core): add ouia compatibility to Switch #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PatternFly-React preview: https://patternfly-react-pr-2304.surge.sh |
|
thanks @redallen I couldn't test changes of this PR in https://patternfly-react-pr-2304.surge.sh/. I set a localStorage variable |
|
@quarckster Gatsby statically renders the site without |
|
After discussion with the OUIA team, this PR is good to merge and have many more followups for all our components that would want integration testing. |
|
@dgutride @karelhala Fixed merge conflicts, please re-approve! |
packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Outdated
Show resolved
Hide resolved
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Fixes #2303 for a Switch by conditionally adding
data-ouia-component-typeanddata-ouia-component-idfor Switch based onwindow.localStorage['ouia'].Do not merge until some further discussion takes place on #2303 .Edit: Discussion has taken place, we can merge now.
Additional issues: