Skip to content

feat(react-core): add ouia compatibility to Switch #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschuler merged 4 commits into from
Jul 8, 2019
+14 −1
Merged

feat(react-core): add ouia compatibility to Switch #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21ad147
feat(react-core): add ouia compatibility to Switch
redallen Jun 19, 2019
f759923
fix doc build
redallen Jun 19, 2019
5b86d18
add types
redallen Jul 3, 2019
f31bd1f
fix typo
redallen Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { css } from '@patternfly/react-styles';
import { CheckIcon } from '@patternfly/react-icons';
import { getUniqueId } from '../../helpers/util';
import { Omit } from '../../helpers/typeUtils';
import { isOUIAEnvironment, getUniqueId as getOUIAUniqueId } from '../../helpers/ouia';

export interface SwitchProps extends Omit<React.HTMLProps<HTMLInputElement>, 'type' | 'onChange' | 'disabled' | 'label'> {
/** id for the label. */
Expand All @@ -24,6 +25,7 @@ export interface SwitchProps extends Omit<React.HTMLProps<HTMLInputElement>, 'ty

export class Switch extends React.Component<SwitchProps> {
id = '';
ouiaId = getOUIAUniqueId();

static defaultProps = {
id: '',
Expand All @@ -47,7 +49,14 @@ export class Switch extends React.Component<SwitchProps> {
render() {
const { className, label, isChecked, isDisabled, onChange, ...props } = this.props;
return (
<label className={css(styles.switch, className)} htmlFor={this.id}>
<label
className={css(styles.switch, className)}
htmlFor={this.id}
{...isOUIAEnvironment() && {
'data-ouia-component-type': 'Switch',
'data-ouia-component-id': this.ouiaId
}}
>
<input
{...props}
id={this.id}
Expand Down
4 changes: 4 additions & 0 deletions packages/patternfly-4/react-core/src/helpers/ouia.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export const isOUIAEnvironment = (): boolean => typeof window !== 'undefined' && window.localStorage.ouia;

let id = 0;
export const getUniqueId = (): number => id++;