feat(Chip): Added OUIA compatibility to Chip component #2995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
9 tasks
Contributor
|
Same deal as with Select in #2996 . |
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2995.surge.sh |
tlabaj
reviewed
Sep 26, 2019
quarckster
changed the title
Contributor
Author
|
@tlabaj fixed |
karelhala
previously approved these changes
Oct 1, 2019
tlabaj
previously approved these changes
Oct 3, 2019
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
can you please resolve merge conflicts so we can merge this one. Thanks
dlabrecq
previously approved these changes
Oct 4, 2019
redallen
previously approved these changes
Oct 4, 2019
quarckster
dismissed stale reviews from redallen, dlabrecq, tlabaj, and karelhala
via
3bccc6e
quarckster
force-pushed
the
chipgroup_ouia
branch
from
eb7c88b to
3bccc6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
+ Coverage 69.02% 69.02% +<.01%
==========================================
Files 858 858
Lines 23413 23430 +17
Branches 1853 1859 +6
==========================================
+ Hits 16160 16172 +12
- Misses 6333 6337 +4
- Partials 920 921 +1
Continue to review full report at Codecov.
|
karelhala
approved these changes
Oct 7, 2019
redallen
approved these changes
Oct 7, 2019
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Added OUIA props to Tabs as per #2425
Additional issues: tests failed with these errors and I cannot figure out what I should do next: