Added OUIA compatibility to Select component

[quarckster]

What: Added OUIA props to Tabs as per #2423

Additional issues: tests failed:

 FAIL  packages/patternfly-4/react-core/src/components/Select/Select.test.tsx
  ● Test suite failed to run

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    packages/patternfly-4/react-core/src/components/Select/Select.tsx:538:47 - error TS2345: Argument of type 'typeof Select' is not assignable to parameter of type 'ComponentClass<SelectProps & InjectedOuiaProps, any> | FunctionComponent<SelectProps & InjectedOuiaProps>'.
      Type 'typeof Select' is not assignable to type 'ComponentClass<SelectProps & InjectedOuiaProps, any>'.
        Types of property 'defaultProps' are incompatible.
          Type '{ "children": ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>[]; ... 21 more ...; "onFilter": () => {}; }' is not assignable to type 'Partial<SelectProps & InjectedOuiaProps>'.
            Types of property 'onClear' are incompatible.
              Type 'Function' is not assignable to type '(event: MouseEvent<Element, MouseEvent>) => void'.
                Type 'Function' provides no match for the signature '(event: MouseEvent<Element, MouseEvent>): void'.

    538 const SelectWithOuiaContext = withOuiaContext(Select);

@redallen @jschuler @karelhala I would appreciate any help with this.

[redallen]

This was a problem with the defaultProps' type, I pushed a change that will hopefully fix it.

[patternfly-build]

PatternFly-React preview: https://patternfly-react-pr-2996.surge.sh

[codecov-io]

Codecov Report

Merging #2996 into master will decrease coverage by 0.04%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
- Coverage   69.02%   68.98%   -0.05%     
==========================================
  Files         858      858              
  Lines       23432    23450      +18     
  Branches     1859     1862       +3     
==========================================
+ Hits        16174    16177       +3     
- Misses       6337     6351      +14     
- Partials      921      922       +1

Flag	Coverage Δ
#misc	95.45% <ø> (ø)	⬆️
#patternfly3	69.22% <ø> (-0.01%)	⬇️
#patternfly4	68% <69.23%> (-0.1%)	⬇️

Impacted Files	Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx	60.93% <69.23%> (-2.4%)	⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js	25% <0%> (-2.42%)	⬇️
...y-react-extensions/src/components/Select/Select.js	19.8% <0%> (+0.2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...7c4d27e. Read the comment docs.

[redallen]

Fixed the type used in a test.

[quarckster]

@redallen I'm afraid I can't fix failed tests. These errors are so cryptic to me.

[karelhala]

@quarckster you gotta update snapshots in order to fix circle build, this can be done by running
node_modules/.bin/jest -u packages/patternfly-4/react-core/src/components/Select

[quarckster]

@karelhala I applied your patch but there are still some errors

[redallen]

If you rebase on latest upstream and run yarn test:pf4 -u I think it should work.

[quarckster]

@redallen tests passed

[tlabaj]

LGTM

[patternfly-build]

Your changes have been released in:

• @patternfly/react-core@3.114.1
• @patternfly/react-docs@4.14.17
• @patternfly/react-inline-edit-extension@2.11.86
• demo-app-ts@3.7.1
• @patternfly/react-table@2.23.2
• @patternfly/react-topology@2.8.79
• @patternfly/react-virtualized-extension@1.2.69

Thanks for your contribution! 🎉