Skip to content

Conversation

@dlabrecq
Copy link
Member

It appears we changed an interface when introducing linting to the react-table package. This is exported, so reverting the breaking change.

fixes #3744

@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 13, 2020

Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Dan!

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #3746 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3746   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files         779      779           
  Lines       10492    10492           
  Branches     2264     2264           
=======================================
  Hits         7474     7474           
  Misses       2592     2592           
  Partials      426      426
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.15% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 69.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa650a3...93f6d80. Read the comment docs.

@ddonahue007 ddonahue007 merged commit 5230f98 into patternfly:master Feb 13, 2020
@dlabrecq dlabrecq deleted the 3744-revert-interface-change branch October 29, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table IHeaderRow interface changed type

5 participants