Skip to content

fix(table): revert IHeaderRow interface change #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddonahue007 merged 1 commit into from
Feb 13, 2020
Merged

fix(table): revert IHeaderRow interface change #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintcache
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion packages/patternfly-4/react-table/src/components/Table/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ export enum SortByDirection {
desc = 'desc'
}

export type IHeaderRow = ColumnType;
// Todo: Update type with next breaking change release
// export type IHeaderRow = ColumnType;

// eslint-disable-next-line @typescript-eslint/interface-name-prefix, @typescript-eslint/no-empty-interface
export interface IHeaderRow extends ColumnType {}

// eslint-disable-next-line @typescript-eslint/interface-name-prefix
export interface IRowData extends IRow {
Expand Down